Repository navigation
Introduce hold mode that is running while hotkey is held down - #41
Merged
Merged
Conversation
robiot
marked this pull request as draft
June 2, 2022 18:17
robiot
marked this pull request as ready for review
June 2, 2022 18:17
robiot
marked this pull request as draft
June 2, 2022 18:18
Better handling for 2 keys #35, Make it work for both holdMode and not
Owner
Author
|
Now it works! The right side looks weird because we have a little bit of free space. |
Owner
Author
|
I'll do that in another pull request! So anyone downloading straight from master will have a nice ui for a bit. 🤣 |
robiot
marked this pull request as ready for review
June 5, 2022 18:24
robiot
added a commit
that referenced
this pull request
Oct 2, 2023
* Change name of current 'hold' mode to 'Button Hold' * Add custom error macro to keep it more clean * Remove brackets around one liner 'else statement' * Move xapp_error to utils * Use bitwise flags for mask_config * Make get_next_key_state return the keystate too, start on logic * New logic for start_stop_key_handler Better handling for 2 keys #35, Make it work for both holdMode and not * Add hold type ComboBox * Remove debug comments and code
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes