Skip to content

Clarify repeat UI - #21

Merged
robiot merged 2 commits into
robiot:masterfrom
vadi2:patch-1
Feb 14, 2022
Merged

robiot merged 2 commits into
robiot:masterfrom
vadi2:patch-1

Conversation

@vadi2

@vadi2 vadi2 commented Feb 9, 2022 •

Copy link
Copy Markdown
Contributor

Clarify repeat UI - link the label to the text field and add a placeholder.

Didn't actually test & compile it, don't have the build system setup - let me know if it needs adjusting.

Fixes #20.

@robiot

robiot commented Feb 10, 2022

Copy link
Copy Markdown
Owner

Looks great, will have to test it first when I have time. If if works I'll merge. Thanks

@robiot

robiot commented Feb 14, 2022 •

Copy link
Copy Markdown
Owner

image
For some reason the UI is unchanged
Nevermind, it might be my clone that is messed up.
I missed that you used another branch.

@robiot

robiot commented Feb 14, 2022

Copy link
Copy Markdown
Owner

image

I've made some small fixes to decrease the size of the "# of times" Textbox and removed the : since it isn't used for any other Textboxes.

If you would want to setup a build enviroment for future contributions or something ¯\_(ツ)_/¯, there is a wiki page for that.

Thank you for your contribution,
Have a nice day!

@robiot
robiot merged commit 29e3d69 into robiot:master Feb 14, 2022
@vadi2
vadi2 deleted the patch-1 branch February 14, 2022 15:24
robiot pushed a commit that referenced this pull request Oct 2, 2023
* Clarify repeat UI

* Adjust text and textbox width to look better

Co-authored-by: Robiot
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Click X amount of times

2 participants