Skip to content

feat: add entries method documentation and example - #81

Merged
roberto-butti merged 2 commits into
roberto-butti:mainfrom
DomeT99:main
Oct 20, 2024
Merged

roberto-butti merged 2 commits into
roberto-butti:mainfrom
DomeT99:main

Conversation

@DomeT99

@DomeT99 DomeT99 commented Oct 12, 2024

Copy link
Copy Markdown
Contributor
  • This PR is for issue New Function: entries() #72
  • It includes a new markdown file explaining the method and its usage, as well as an example file demonstrating use case.

If there are any problems, I remain available :)

@vercel

vercel Bot commented Oct 12, 2024 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
some-drops-of-javascript ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 17, 2024 3:27pm

@roberto-butti

Copy link
Copy Markdown
Owner

Hi @DomeT99 this is a great PR. Thank you for your time and commitment.
I'll give you a suggestion. Let's see if you agree.
I know we are in the array section, but in this explanation, i would like to mention that entries() is available for Object and Map adding a brief explanation and a short example (one for Object and one for Map).
Thank you!

@DomeT99

DomeT99 commented Oct 14, 2024

Copy link
Copy Markdown
Contributor Author

Hi @roberto-butti
It's a good idea!
You could mention that entries() is a method of both Map and Object with a small example and then insert a link to the page specific for more information.
Let me know :)

@roberto-butti

Copy link
Copy Markdown
Owner

@DomeT99 do you want to add it as part of this PR?

@DomeT99

DomeT99 commented Oct 17, 2024

Copy link
Copy Markdown
Contributor Author

No problems.

@roberto-butti

Copy link
Copy Markdown
Owner

Thank you @DomeT99 for the PR and for your addings.
Magical

I'm going to merge it

@roberto-butti roberto-butti added hacktoberfest Issues opened for Hacktoberfest. Your contribution is welcomed hacktoberfest-accepted labels Oct 20, 2024
@roberto-butti
roberto-butti merged commit 0480341 into roberto-butti:main Oct 20, 2024
@roberto-butti roberto-butti mentioned this pull request Oct 20, 2024
5 tasks

This branch was successfully deployed

1 active deployment
Preview — b185dc64 Deployed Oct 17, 2024 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hacktoberfest Issues opened for Hacktoberfest. Your contribution is welcomed hacktoberfest-accepted

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants