Skip to content

fix: use stricter types for renovate config - #39594

Merged
viceice merged 4 commits into
mainfrom
fix/stricter-types
Nov 28, 2025
Merged

viceice merged 4 commits into
mainfrom
fix/stricter-types

Conversation

@viceice

@viceice viceice commented Nov 27, 2025 •

Copy link
Copy Markdown
Member

Changes

Context

Please select one of the following:

  • This closes an existing Issue, Closes: #
  • This doesn't close an Issue, but I accept the risk that this PR may be closed if maintainers disagree with its opening or implementation

AI assistance disclosure

Did you use AI tools to create any part of this pull request?

Please select one option and, if yes, briefly describe how AI was used (e.g., code, tests, docs) and which tool(s) you used.

  • No — I did not use AI for this contribution.
  • Yes — minimal assistance (e.g., IDE autocomplete, small code completions, grammar fixes).
  • Yes — substantive assistance (AI-generated non‑trivial portions of code, tests, or documentation).
  • Yes — other (please describe):

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests, but ran on a real repository, or
  • Both unit tests + ran on a real repository

The public repository:

@jamietanna jamietanna left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As an aside, do we have a type for only repo config? Is that RenovateSharedConfig?

(I can raise a follow-up PR to add some JSDoc for the various types and what they're for)

Comment thread lib/config/types.ts

@jamietanna jamietanna left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Validated there's no change to the JSON Schema 👍

Comment thread lib/config/types.ts Outdated
Comment thread lib/config/types.ts
Comment thread lib/config/types.ts Outdated
Comment thread lib/config/types.ts Outdated
@viceice
viceice requested a review from jamietanna November 28, 2025 10:15
@viceice
viceice enabled auto-merge November 28, 2025 12:28
@viceice
viceice added this pull request to the merge queue Nov 28, 2025
Merged via the queue into main with commit c641239 Nov 28, 2025
41 checks passed
@viceice
viceice deleted the fix/stricter-types branch November 28, 2025 13:23
@github-actions

Copy link
Copy Markdown
Contributor

🎉 This PR is included in version 42.26.6 🎉

The release is available on:

Your semantic-release bot 📦🚀

@viceice viceice added the regression Issue about a regression bug, or the PR caused it label Nov 29, 2025
@viceice viceice mentioned this pull request Nov 29, 2025
4 of 12 tasks
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Dec 30, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

audience:maintainer bucket:engineering-health regression Issue about a regression bug, or the PR caused it

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants