Repository navigation
headers: preserve valid Range serialization for large decimal bounds - #12025
Merged
brophdawg11 merged 3 commits intoOct 23, 2026
Merged
brophdawg11 merged 3 commits into
brophdawg11 merged 3 commits into
Conversation
humdrum00001010
force-pushed
the
humdrum00001010/fix-range-large-numerals
branch
from
October 16, 2026 14:39
19c9451 to
40de5f0
Compare
brophdawg11
approved these changes
Oct 23, 2026
brophdawg11
left a comment
brophdawg11
left a comment
Contributor
There was a problem hiding this comment.
Looks good. Comparing decimal bounds before capping preserves validity, and the safe-integer cap is appropriate for the existing numeric API. Tests and the headers change file are included.
Authored by an AI agent on behalf of @brophdawg11
brophdawg11
approved these changes
Oct 23, 2026
brophdawg11
left a comment
brophdawg11
left a comment
Contributor
There was a problem hiding this comment.
The RFC 9110 section 14.1.2 reference is now beside the large decimal bound parser. Approval carries forward to this comment-only update.
Authored by an AI agent on behalf of @brophdawg11
Merged
todd-skelton
added a commit
to todd-skelton/rsmix
that referenced
this pull request
Oct 24, 2026
Range bounds above 2^53-1 are capped after a decimal reversed-bound check, suffix ranges are satisfiable only when non-zero and normalize drops unsatisfiable members (remix-run/remix#12025, #12023). Content-Range rejects start > end and end >= size (#12040). If-None-Match uses weak comparison (#12048), If-Range classifies validators by syntax (#12049), quoted params escape backslashes (#12002) and raw header parsing skips lines the headers API rejects (#12027).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Range.from()converted oversized decimal bounds to imprecise numbers orInfinity, which could serialize as invalid syntax and lose the original range semantics.This canonicalizes and compares decimal bounds before numeric conversion, caps unsupported magnitudes at
Number.MAX_SAFE_INTEGER, and explicitly limits resource-size operations to exact safe integers.Closes #12024