Skip to content

add docs builds to Github Actions - #481

Merged
rapids-bot[bot] merged 8 commits into
rapidsai:branch-23.02from
AjayThorve:add-build-docs-GH
Jan 20, 2023
Merged

rapids-bot[bot] merged 8 commits into
rapidsai:branch-23.02from
AjayThorve:add-build-docs-GH

Conversation

@AjayThorve

@AjayThorve AjayThorve commented Jan 19, 2023 •

Copy link
Copy Markdown
Member

The PR adds a docs_build process to the PR and Build workflows for this repository. The generated docs are synced to s3 for only the build workflows.

docs build are failing when I tried to run locally. WIP until we figure out the issue.

edit: docs build was failing due to a newer sphinx version, pinning it to <=5.3.0 fixes the issue

cc @ajschmidt8

@AjayThorve
AjayThorve requested a review from a team as a code owner January 19, 2023 23:19
@AjayThorve AjayThorve changed the title [WIP] add docs builds to Github Actions add docs builds to Github Actions Jan 19, 2023
@codecov-commenter

codecov-commenter commented Jan 20, 2023 •

Copy link
Copy Markdown

Codecov Report

Base: 92.95% // Head: 92.95% // No change to project coverage 👍

Coverage data is based on head (f63b61d) compared to base (2acc027).
Patch has no changes to coverable lines.

Additional details and impacted files
@@              Coverage Diff              @@
##           branch-23.02     #481   +/-   ##
=============================================
  Coverage         92.95%   92.95%           
=============================================
  Files               130      130           
  Lines              9775     9775           
=============================================
  Hits               9086     9086           
  Misses              689      689           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Comment thread ci/build_docs.sh
Comment thread ci/build_docs.sh Outdated
@ajschmidt8 ajschmidt8 added improvement Improves an existing functionality non-breaking Introduces a non-breaking change labels Jan 20, 2023

@ajschmidt8 ajschmidt8 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

last suggestion and then we can merge this.

Comment thread dependencies.yaml
Co-authored-by: AJ Schmidt <ajschmidt8@users.noreply.github.com>
@ajschmidt8

Copy link
Copy Markdown
Member

/merge

@rapids-bot
rapids-bot Bot merged commit 8a66080 into rapidsai:branch-23.02 Jan 20, 2023
@jakirkham

Copy link
Copy Markdown
Member

Thank you both! 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

improvement Improves an existing functionality non-breaking Introduces a non-breaking change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants