Repository navigation
Fix random seed used in test_3d_similarity_estimation - #472
Merged
rapids-bot[bot] merged 1 commit intoJan 4, 2023
Conversation
some choices of random parameters can be poorly conditioned, leading to NaN in the output
grlee77
added
bug
jakirkham
reviewed
Jan 4, 2023
Comment on lines
+152
to
+154
| seed = 10 | ||
| rng = cp.random.default_rng(seed) | ||
| src_points = rng.random(size=(1000, 3)) |
Member
There was a problem hiding this comment.
Maybe we should consider parameterizing these. Though that can be a follow up item separate from this PR
jakirkham
approved these changes
Jan 4, 2023
Member
|
Thanks Greg! 🙏 |
Member
|
@gpucibot merge |
Contributor
|
@jakirkham, the Please re-comment this PR with |
Member
|
/merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This MR fixes the random seed used in
test_3d_similarity_estimationto avoid a stochastic test failure observed both locally and on CI. While fixing the seed, the test case is also updated to use the newer styleRandomGeneratorAPI.