Repository navigation
update incorrect argument and deprecated function for tifffile.TiffWriter - #433
Conversation
1. ```TiffWriter.write()``` receives ```compression``` instead of ```compress``` 2. ```TiffWriter.write()`` instead of ```TiffWriter.save()``
|
Thanks for fixing the issue @JoohyungLee0106. I looked into the history of the API change and don't think we may not need to support a fallback code path for older We already pinned to a newer version in our test requirements here: https://github.com/rapidsai/cucim/blob/branch-22.12/python/cucim/requirements-test.txt However, I do see a few files pinned to a specific, older version: |
|
Can one of the admins verify this patch? Admins can comment |
1 similar comment
|
Can one of the admins verify this patch? Admins can comment |
grlee77
added
bug
|
ok to test |
|
@grlee77 those requirement files are not used in anywhere (it was used when cuCIM was released as a separate package but those need to be removed in the future). Updated this PR to add a test case and update the hard-coded version. |
Signed-off-by: Gigon Bae <gbae@nvidia.com>
Signed-off-by: Gigon Bae <gbae@nvidia.com>
|
@gigony, looks like we have to add opencv-python to |
grlee77
left a comment
grlee77
left a comment
There was a problem hiding this comment.
This looks good, assuming CI passes this time around.
Conda doesn't have opencv-python package (instead, it has opencv), so we need to use pip for installing test dependencies.
Signed-off-by: Gigon Bae <gbae@nvidia.com>
grlee77
left a comment
grlee77
left a comment
There was a problem hiding this comment.
Thanks Gigon, everything looks good now.
|
@gpucibot merge |
|
Thanks again, @JoohyungLee0106. This fix will appear in the 2022.12.00 release (sometime around Dec 7) |
If you want to use no compression method for your converted file, you can set the compression method to None in the converter. In CLI, you can use `--compression` option and set it to any string except `jpeg`. E.g., ``` cucim convert --tile-size 512 --overlap 0 --num-workers 12 --output-filename resize.tiff --compression RAW notebooks/input/TUPAC-TR-467.svs ``` The converter will then convert the file without any compression. Need to update test cases once #433 is merged. Signed-off-by: Gigon Bae <gbae@nvidia.com> Authors: - Gigon Bae (https://github.com/gigony) - Gregory Lee (https://github.com/grlee77) Approvers: - Gregory Lee (https://github.com/grlee77) URL: #443
tifffile.TiffWriter.write()[link] andtifffile.TiffWriter.save()[link] receivecompressionnotcompress-> Current version doesn't work and raises the following error msg:
tifffile.TiffWriter.write()instead oftifffile.TiffWriter.save(), which has been deprecated [link]