Repository navigation
Incorporate bug fixes from skimage 0.19.3 - #312
Merged
rapids-bot[bot] merged 4 commits intoJun 16, 2022
Merged
Conversation
This is an adaptation of the following PR included in skimage 0.19.3: scikit-image/scikit-image#6335
This is a port of the following fix included in skimage 0.19.3: scikit-image/scikit-image#6413
grlee77
added
bug
Member
|
rerun tests |
jakirkham
reviewed
Jun 15, 2022
Co-authored-by: jakirkham <jakirkham@gmail.com>
Contributor
Author
|
Thanks for fixing the linting issue @jakirkham. I think we will still first need the bug fix in #310 in order for this PR to pass. |
Member
|
rerun tests |
jakirkham
approved these changes
Jun 16, 2022
Member
|
@gpucibot merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR incorporates the two bug fixes from skimage v0.19.3 (released on June 12th) that are relevant to cuCIM.
cucim.skimage.exposure.histogramcvalduring clipping even if it is outside the original image rangeThere was also a fix to Canny edge detection, but we had already resolved that issue in cuCIM. I did go ahead and add the new test case for it to #310.