Skip to content

Update to use DLPack v0.6 - #295

Merged
rapids-bot[bot] merged 1 commit into
rapidsai:branch-22.06from
gigony:update_dlpackv0.6-67
Jun 1, 2022
Merged

Update to use DLPack v0.6#295
rapids-bot[bot] merged 1 commit into
rapidsai:branch-22.06from
gigony:update_dlpackv0.6-67

Conversation

@gigony

@gigony gigony commented May 26, 2022

Copy link
Copy Markdown
Contributor

Update DLPack version from v0.3 to v0.6

  • Rename kPinned => kCUDAHost
  • Fix class/field names
    • Rename DLContext -> DLDevice
    • DLTensor.ctx -> DLTensor.device
  • Add kCudaManaged type

The followings are updates from the DLPack header file:

v0.6

  • Add kDLROCMHost
  • Add kDLCUDAManaged

v0.5

  • kDLGPU -> kDLCUDA
  • kDLCPUPinned -> kDLCUDAHost

v0.4

  • OpaqueHandle type
  • Complex support
  • Rename DLContext -> DLDevice
    • DLTensor.ctx -> DLTensor.device
    • This requires dependent frameworks to upgrade the type name.
    • The ABI is backward compatible, as it is only change of constant name, exchange can still happen between the new version and old version.

Address #67

Signed-off-by: Gigon Bae gbae@nvidia.com

@gigony
Update to use DLPack v0.6
0d3254d 
Signed-off-by: Gigon Bae <gbae@nvidia.com>
@gigony gigony added improvement Improves an existing functionality non-breaking Introduces a non-breaking change labels May 26, 2022
@gigony gigony added this to the v22.06.00 milestone May 26, 2022
@gigony
gigony requested a review from a team as a code owner May 26, 2022 00:30
@gigony gigony self-assigned this May 26, 2022
@gigony
gigony requested a review from a team as a code owner May 26, 2022 00:30
grlee77
grlee77 approved these changes May 26, 2022
View reviewed changes

@grlee77 grlee77 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Gigon, looks great!

@jakirkham

jakirkham commented Jun 1, 2022

Copy link
Copy Markdown
Member

@gpucibot merge

@rapids-bot
rapids-bot Bot merged commit db7c03c into rapidsai:branch-22.06 Jun 1, 2022
@jakirkham

jakirkham commented Jun 1, 2022

Copy link
Copy Markdown
Member

Thanks Gigon! 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jakirkham jakirkham jakirkham approved these changes
@grlee77 grlee77 grlee77 approved these changes

Assignees

@gigony gigony

Labels

improvement Improves an existing functionality non-breaking Introduces a non-breaking change

Projects

None yet

Milestone

v22.06.00

Development

Successfully merging this pull request may close these issues.

3 participants

@gigony @jakirkham @grlee77