Skip to content

Populate correct channel names for RGBA image - #294

Merged
rapids-bot[bot] merged 1 commit into
rapidsai:branch-22.06from
gigony:fix_issue-262
Jun 1, 2022
Merged

rapids-bot[bot] merged 1 commit into
rapidsai:branch-22.06from
gigony:fix_issue-262

Conversation

@gigony

@gigony gigony commented May 25, 2022

Copy link
Copy Markdown
Contributor

Fix a segmentation fault raised when loading RGBA image and accessing metadata.

Addresses #262
Signed-off-by: Gigon Bae gbae@nvidia.com

@gigony gigony added bug Something isn't working non-breaking Introduces a non-breaking change labels May 25, 2022
@gigony gigony added this to the v22.06.00 milestone May 25, 2022
@gigony gigony self-assigned this May 25, 2022
@gigony
gigony requested review from a team as code owners May 25, 2022 22:34

@grlee77 grlee77 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One question/suggestion, but otherwise this looks good.

I appreciate the new test case. Do you think we should also have a version with a 2D grayscale image?

Comment thread cpp/plugins/cucim.kit.cuslide/src/cuslide/cuslide.cpp
Signed-off-by: Gigon Bae <gbae@nvidia.com>
@jakirkham

Copy link
Copy Markdown
Member

@gpucibot merge

@rapids-bot
rapids-bot Bot merged commit ccfdb83 into rapidsai:branch-22.06 Jun 1, 2022
@jakirkham

Copy link
Copy Markdown
Member

Thanks Gigon! 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working non-breaking Introduces a non-breaking change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants