Skip to content

MAINT: avoid use of deprecated cp.float, cp.int, cp.bool - #29

Merged
rapids-bot[bot] merged 1 commit into
rapidsai:branch-0.20from
grlee77:remove-use-of-deprecated-types
May 12, 2021
Merged

rapids-bot[bot] merged 1 commit into
rapidsai:branch-0.20from
grlee77:remove-use-of-deprecated-types

Conversation

@grlee77

@grlee77 grlee77 commented May 12, 2021

Copy link
Copy Markdown
Contributor

This PR silences a number of warnings when running the tests with the current CuPy development branch. As in NumPy, these types are deprecated and float, int or bool should be used instead.

@grlee77 grlee77 added the non-breaking Introduces a non-breaking change label May 12, 2021
@grlee77
grlee77 requested a review from a team as a code owner May 12, 2021 01:42
@grlee77 grlee77 added the bug Something isn't working label May 12, 2021
@grlee77

grlee77 commented May 12, 2021

Copy link
Copy Markdown
Contributor Author

not sure if we should create a new "maintenance" label? I marked it as "bug" for now, but it is really preventing a future bug if these dtypes actually get removed.

@jakirkham

Copy link
Copy Markdown
Member

Yeah the labels are configured by RAPIDS OPS, but we can ask

@jakirkham

Copy link
Copy Markdown
Member

@gpucibot merge

@rapids-bot
rapids-bot Bot merged commit 0c14c8d into rapidsai:branch-0.20 May 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working non-breaking Introduces a non-breaking change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants