Repository navigation
Do not compile code with nvcc if no CUDA kernel exists - #171
Merged
Merged
Conversation
Member
|
rerun tests |
jakirkham
approved these changes
Dec 1, 2021
Member
|
There seem to be some test failures in this job, but they are coming from CuPy calls, which don't seem related to this change |
Member
|
After looking into this more, am thinking this failure may be related, but unclear how. Not seeing this failure in Greg's PR ( #172 ) and it is reproducing here. The CuPy error suggests it came up before CuPy was invoked. So the cause may be elsewhere. May need a more detailed traceback |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, cuCIM code links CUDA runtime by creating PTX code explicitly (changing LANGUAGE to CUDA) even though cuCIM code (in C++) currently doesn't have any CUDA kernels.
That causes the issue with CuPy, causing the following error message (#170)
The error is related to the nvcc version (from cuda 11.5) used in RAPIDS GPUCI.
https://docs.nvidia.com/cuda/cuda-runtime-api/group__CUDART__TYPES.html#group__CUDART__TYPES_1gg3f51e3575c21[…]e003844fd2df23a72a9ee7364d30150ae7e9e
With CUDA toolkit (nvcc) v11.4, it doesn't cause the error.
Fix the error by linking libcudart.so explicitly.
Also fixes warnings.
Close #170