Skip to content

Add Jupyter notebook for SVS Support - #147

Merged
rapids-bot[bot] merged 2 commits into
rapidsai:branch-21.12from
gigony:supporting_svs_notebook
Nov 20, 2021
Merged

rapids-bot[bot] merged 2 commits into
rapidsai:branch-21.12from
gigony:supporting_svs_notebook

Conversation

@gigony

@gigony gigony commented Nov 10, 2021

Copy link
Copy Markdown
Contributor
  • Update notebooks/Welcome.ipynb
  • Add notebooks/Supporting_Aperio_SVS_Format.ipynb to show loading Aperio SVS images

@gigony gigony added the doc Improvements or additions to documentation label Nov 10, 2021
@gigony gigony added this to the v21.12.00 milestone Nov 10, 2021
@gigony
gigony requested review from jakirkham and quasiben November 10, 2021 10:26
@gigony gigony self-assigned this Nov 10, 2021
@gigony gigony changed the title Add Jupyter notebook for SVS Support. Add Jupyter notebook for SVS Support Nov 10, 2021
@gigony
gigony force-pushed the supporting_svs_notebook branch from ca29ea1 to 0fe468b Compare November 11, 2021 18:36
@jakirkham

Copy link
Copy Markdown
Member

rerun tests

@gigony gigony added the non-breaking Introduces a non-breaking change label Nov 17, 2021
@jakirkham

jakirkham commented Nov 18, 2021 •

Copy link
Copy Markdown
Member

There's some commented code in the notebook like

#         start_loc_data = [(sx, sy)
...

Should we drop that?

Edit: Also wonder if we should break the Experiment Code section out into a script

@gigony
gigony force-pushed the supporting_svs_notebook branch from 0fe468b to eb0e123 Compare November 20, 2021 19:44
@gigony

gigony commented Nov 20, 2021

Copy link
Copy Markdown
Contributor Author

There's some commented code in the notebook like

#         start_loc_data = [(sx, sy)
...

Should we drop that?

Edit: Also wonder if we should break the Experiment Code section out into a script

Good idea! Thank you for the suggestion. Moved as scripts and removed unnecessary comments.

@jakirkham

Copy link
Copy Markdown
Member

@gpucibot merge

@rapids-bot
rapids-bot Bot merged commit e3ce50d into rapidsai:branch-21.12 Nov 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

doc Improvements or additions to documentation non-breaking Introduces a non-breaking change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants