[TamasSzigeti]

Description

Fix missing working dir when getting composer cache dir config
Bumping included composer.phar version to fix CI error – to the minimum that has this fix

Motivation and context

Fixes #225

How has this been tested?

Tested by manually running composer_paths.sh in a directory where there is no composer.lock
Current tests do not fail because there is another composer.lock in tests dir.
Added another test case, hope it works (:

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)

PR checklist

• My change requires a change to the documentation.
• I have updated the documentation accordingly.
• I have read the CONTRIBUTING.md document.
• I have added tests to cover my changes.

[TamasSzigeti]

@ramsey Could you have a look, please?

[TamasSzigeti]

@ramsey Fixed the (unrelated) CI error before I noticed it is also done in #237
This should be green now

[TamasSzigeti]

@ramsey Fixed conflict

[TamasSzigeti]

@ramsey Seems the v1 fail already happens in upstream branch, so this might be good to go?

[ramsey]

@TamasSzigeti Please update your branch with the latest upstream changes. Thanks!

[TamasSzigeti]

@TamasSzigeti Please update your branch with the latest upstream changes. Thanks!

@ramsey Done

[TamasSzigeti]

@ramsey Adjusted the test for the changed github output

[TamasSzigeti]

@ramsey Is there anything yet to be done here?

[ramsey]

@TamasSzigeti Are you able to fix the test failures?

[TamasSzigeti]

@ramsey
When it failed it was already failing in master, not coming from my changes. I rebased and will fix if it still fails

[petemcw]

Has there been any further progress on this? I can report that caching does not work correctly when using a "working-directory" input.

[mxr576]

Meh, I had just opened a duplicate in #247 before I found this 🤦‍♂️

[mxr576]

Related issue: #246

[TamasSzigeti]

@mxr576 I totally forgot about this PR, maybe you could take it over, fix tests?

[mxr576]

@mxr576 I totally forgot about this PR, maybe you could take it over, fix tests?

I cannot make any promises, tests were not executed on my PR because I am a first time contributor and I do not see failures due to: "The logs for this run have expired and are no longer available."

Rebasing/retriggering the build could be useful

[ramsey]

@mxr576 If you want to reopen your PR, I can click the button to allow the tests to run.

[mxr576]

Thanks, reopened

[TamasSzigeti]

@ramsey Sorry for taking this long, I fixed the tests, should be all green now.

[mxr576]

@mxr576 I totally forgot about this PR, maybe you could take it over, fix tests?

Same here... ;S thx!!! \o/

[codecov]

Codecov Report

Merging #233 (d68c9ba) into v2 (12e7194) will not change coverage.
The diff coverage is 100.00%.

Additional details and impacted files

@@           Coverage Diff           @@
##               v2     #233   +/-   ##
=======================================
  Coverage   84.23%   84.23%           
=======================================
  Files           7        7           
  Lines         203      203           
=======================================
  Hits          171      171           
  Misses         32       32           

Files	Coverage Δ
bin/composer_paths.sh	97.43% <100.00%> (ø)

[ramsey]

Thank you!