Skip to content

mimetypes.guess_type("//example.com") misinterprets host name as file name #66543

Closed
Closed
mimetypes.guess_type("//example.com") misinterprets host name as file name#66543
Labels
3.11only security fixes3.12only security fixes3.13only security fixesstdlibStandard Library Python modules in the Lib/ directorytype-bugAn unexpected behavior, bug, or error

Description

@vadmium
vadmium
opened on Sep 6, 2014
BPO 22347
Nosy @ned-deily, @vadmium, @maxking, @corona10, @miss-islington
PRs
  • bpo-22347: Update mimetypes.guess_type to allow proper parsing of URLs #15522
  • [3.8] bpo-22347: Update mimetypes.guess_type to allow proper parsing of URLs (GH-15522) #15685
  • [3.7] bpo-22347: Update mimetypes.guess_type to allow proper parsing of URLs (GH-15522) #15687
  • bpo-38449: Revert "bpo-22347: Update mimetypes.guess_type to allow oper parsing of URLs (GH-15522)" #16724
  • [3.7] bpo-38449: Revert "bpo-22347: Update mimetypes.guess_type to allow oper parsing of URLs (GH-15522)" (GH-16724) #16725
  • [3.7] bpo-38449: Revert "bpo-22347: Update mimetypes.guess_type to allow oper parsing of URLs (GH-15685)" (GH-16724) #16727
  • [3.8] bpo-38449: Revert "bpo-22347: Update mimetypes.guess_type to allow oper parsing of URLs (GH-15685)" (GH-16724) #16728
    		•
    Dependencies
  • bpo-35939: Remove urllib.parse._splittype from mimetypes.guess_type
    		•
    Files
  • mimetypes-host.patch
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
closed_at = None
created_at = <Date 2014-09-06.02:52:37.225>
labels = ['3.7', '3.8', 'type-bug', 'library']
title = 'mimetypes.guess_type("//example.com") misinterprets host name as file name'
updated_at = <Date 2019-10-15.07:30:25.613>
user = 'https://github.com/vadmium'

    bugs.python.org fields:

    activity = <Date 2019-10-15.07:30:25.613>
actor = 'ned.deily'
assignee = 'none'
closed = False
closed_date = None
closer = None
components = ['Library (Lib)']
creation = <Date 2014-09-06.02:52:37.225>
creator = 'martin.panter'
dependencies = ['35939']
files = ['38222']
hgrepos = []
issue_num = 22347
keywords = ['patch']
message_count = 15.0
messages = ['226467', '236479', '335123', '351156', '351157', '351158', '351162', '351164', '351167', '354471', '354521', '354535', '354538', '354543', '354697']
nosy_count = 5.0
nosy_names = ['ned.deily', 'martin.panter', 'maxking', 'corona10', 'miss-islington']
pr_nums = ['15522', '15685', '15687', '16724', '16725', '16727', '16728']
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'open'
superseder = None
type = 'behavior'
url = 'https://bugs.python.org/issue22347'
versions = ['Python 3.7', 'Python 3.8']

    Linked PRs

    Activity

    1. vadmium commented on Sep 6, 2014

      @vadmium
      vadmium
      on Sep 6, 2014
      MemberAuthor

      The documentation says that guess_type() takes a URL, but:

      >>> mimetypes.guess_type("http://example.com")
('application/x-msdownload', None)

      I suspect the MS download is a reference to *.com files (like DOS's command.com). My current workaround is to strip out the host name from the URL, since I cannot imagine it would be useful for determining the content type. I am also stripping the fragment part. An argument could probably be made for stripping the “;parameters” and “?query” parts as well.

      >>> # Workaround for mimetypes.guess_type("//example.com")
... # interpreting host name as file name
... url = urlparse("http://example.com")
>>> url = net.url_replace(url, netloc="", fragment="")
>>> url
'http://'
>>> mimetypes.guess_type(url, strict=False)
(None, None)
    2. vadmium
      added
      stdlibStandard Library Python modules in the Lib/ directory
      type-bugAn unexpected behavior, bug, or error
      on Sep 6, 2014

    3. vadmium commented on Feb 24, 2015

      @vadmium
      vadmium
      on Feb 24, 2015
      MemberAuthor

      Posting a patch to fix this. It passes the URL through a urlsplit() → urlunsplit() stage, while removing the scheme://netloc parts.

    4. corona10 commented on Feb 9, 2019

      @corona10
      corona10
      on Feb 9, 2019
      Member

      The proposed patch I mentioned on bpo-35939 also solve the above situation.

      Python 3.8.0a1+ (heads/bpo-12317:96d37dbcd2, Feb  8 2019, 12:03:40)
[Clang 9.1.0 (clang-902.0.39.1)] on darwin
Type "help", "copyright", "credits" or "license" for more information.
>>> import mimetypes
>>> mimetypes.guess_type("http://example.com")
(None, None)
>>> mimetypes.guess_type("example.com")
('application/x-msdownload', None)
>>>

      I've also added the unit tests of mimetypes-host.patch. It works well.
      I think that we close this issue also when the bpo-35939 is closed.

      Thanks alot!

    5. corona10
      added
      3.7 (EOL)end of life
      3.8 (EOL)end of life
      on Feb 9, 2019

    6. miss-islington commented on Sep 5, 2019

      @miss-islington
      miss-islington
      on Sep 5, 2019
      Contributor

      New changeset 87bd207 by Miss Islington (bot) (Dong-hee Na) in branch 'master':
      bpo-22347: Update mimetypes.guess_type to allow proper parsing of URLs (GH-15522)
      87bd207

    7. miss-islington commented on Sep 5, 2019

      @miss-islington
      miss-islington
      on Sep 5, 2019
      Contributor

      New changeset 6d7a786 by Miss Islington (bot) in branch '3.8':
      bpo-22347: Update mimetypes.guess_type to allow proper parsing of URLs (GH-15522)
      6d7a786

    8. miss-islington commented on Sep 5, 2019

      @miss-islington
      miss-islington
      on Sep 5, 2019
      Contributor

      New changeset 8873bff by Miss Islington (bot) (Dong-hee Na) in branch '3.7':
      [3.7] bpo-22347: Update mimetypes.guess_type to allow proper parsing of URLs (GH-15522) (GH-15687)
      8873bff

    9. corona10 commented on Sep 5, 2019

      @corona10
      corona10
      on Sep 5, 2019
      Member

      @vstinner(my mentor) @maxking
      Now this issue is solved.
      I'd like to close this issue. Is it okay?

    10. maxking commented on Sep 5, 2019

      @maxking
      maxking
      on Sep 5, 2019
      Contributor

      I think so, yes.

      Also, while you are at it, can you also close bpo-35939 with a comment that points to this issue and the right PR for the fix?

    11. corona10 commented on Sep 5, 2019

      @corona10
      corona10
      on Sep 5, 2019
      Member

      Great! I will close bpo-35939 also.

    12. corona10
      closed this as completedon Sep 5, 2019

    13. ned-deily commented on Oct 11, 2019

      @ned-deily
      ned-deily
      on Oct 11, 2019
      Member

      This change introduces a potential 3.7 regression; see bpo-38449.

    14. 15 remaining items

    15. serhiy-storchaka
      added
      3.13only security fixes
      on Mar 26, 2024
    16. serhiy-storchaka
      added a commit that references this issue on Mar 26, 2024

      gh-66543: Fix mimetype.guess_type() (GH-117217)

      9654daf
    17. miss-islington
      added 2 commits that reference this issue on Mar 26, 2024

      pythongh-66543: Fix mimetype.guess_type() (pythonGH-117217)

      17d81ce

      pythongh-66543: Fix mimetype.guess_type() (pythonGH-117217)

      4f8ce2d
    18. serhiy-storchaka
      added 3 commits that reference this issue on Mar 26, 2024

      [3.12] gh-66543: Fix mimetype.guess_type() (GH-117217) (GH-117256)

      36b1a20

      [3.11] gh-66543: Fix mimetype.guess_type() (GH-117217) (GH-117257)

      2d93236

      pythongh-66543: Add mimetypes.guess_file_type()

      97aa88a

    19. serhiy-storchaka commented on Mar 26, 2024

      @serhiy-storchaka
      serhiy-storchaka
      on Mar 26, 2024
      Member

      #117258 adds guess_file_type(). Passing file path in guess_type() is deprecated in documentation only. There are too many uses of guess_type() with a file path, so emitting a deprecation warning at runtime will be added many years later.

      In addition, guess_file_type() works with bytes paths. guess_type() always returns (None, None) and may emit a bytes warning.

      Yet one difference: file foo\.html is considered an HTML file on Posix, but has an unknown MIME type on Windows.

    20. serhiy-storchaka
      added a commit that references this issue on Mar 26, 2024

      pythongh-66543: Add mimetypes.guess_file_type()

      a86c8dd
    21. NGRsoftlab
      added 2 commits that reference this issue on Apr 2, 2024

      Squashed commit of the following:

      1b5fe4c

      Squashed commit of the following:

      a016a54
    22. diegorusso
      added a commit that references this issue on Apr 17, 2024

      pythongh-66543: Fix mimetype.guess_type() (pythonGH-117217)

      13bf03d
    23. serhiy-storchaka
      added a commit that references this issue on May 6, 2024

      gh-66543: Add mimetypes.guess_file_type() (GH-117258)

      d6fa1d4
    24. serhiy-storchaka
      closed this as completedon May 6, 2024
    25. SonicField
      added a commit that references this issue on May 8, 2024

      pythongh-66543: Add mimetypes.guess_file_type() (pythonGH-117258)

      29d6d4c
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

    Metadata

    Metadata

    Assignees

    No one assigned

      Labels

      3.11only security fixes3.12only security fixes3.13only security fixesstdlibStandard Library Python modules in the Lib/ directorytype-bugAn unexpected behavior, bug, or error

      Projects

      No projects

        Milestone

        No milestone

        Relationships

        None yet

        Development

        No branches or pull requests

        Issue actions