Skip to content

poplib.py: Missing integer parsing validation causes client crash on invalid server response #130637

Closed
#130646
Closed
poplib.py: Missing integer parsing validation causes client crash on invalid server response#130637
#130646
Labels
stdlibStandard Library Python modules in the Lib/ directorytype-bugAn unexpected behavior, bug, or error

Description

@NErinola
NErinola
opened on Feb 27, 2025

Crash report

What happened?

In poplib.py at line 229 the code attempts to convert a server response to an integer without first verifying that the response is numeric. If the server returns a non-numeric response, the int() conversion fails causing the client to crash.

CPython versions tested on:

3.12

Operating systems tested on:

Linux

Output from running 'python -VV' on the command line:

No response

Linked PRs

Activity

  1. NErinola
    added
    type-crashA hard crash of the interpreter, possibly with a core dump
    on Feb 27, 2025
  2. Mr-Sunglasses
    added a commit that references this issue on Feb 27, 2025

    pythongh-130637: Add validation for numeric response data in `stat()`…

    18dfd83
  3. encukou
    added
    type-bugAn unexpected behavior, bug, or error
    stdlibStandard Library Python modules in the Lib/ directory
    and removed
    type-crashA hard crash of the interpreter, possibly with a core dump
    on Feb 28, 2025

  4. encukou commented on Feb 28, 2025

    @encukou
    encukou
    on Feb 28, 2025
    Member

    This is a wrong exception (ValueError), not a hard crash, right?

  5. ericvsmith
    added a commit that references this issue on Mar 2, 2025

    gh-130637: Add validation for numeric response data in `stat()` method (

    a42168d
  6. ericvsmith
    closed this as completedin #130646on Mar 2, 2025
  7. miss-islington
    added 2 commits that reference this issue on Mar 2, 2025

    pythongh-130637: Add validation for numeric response data in `stat()`…

    bbab776

    pythongh-130637: Add validation for numeric response data in `stat()`…

    9148113
  8. terryjreedy
    added 2 commits that reference this issue on Mar 2, 2025

    [3.12] gh-130637: Add validation for numeric response data in `stat()…

    d9ca98a

    [3.13] gh-130637: Add validation for numeric response data in `stat()…

    e6dfa9d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    stdlibStandard Library Python modules in the Lib/ directorytype-bugAn unexpected behavior, bug, or error

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions