MemoryError freelist is not thread-safe in free threaded build

Bug report

The MemoryError freelist isn't thread-safe if the GIL is disabled:

Lines 3850 to 3860 in 285c1c4

    
           /* Fetch object from freelist and revive it */ 
        
           self = state->memerrors_freelist; 
        
           self->args = PyTuple_New(0); 
        
           /* This shouldn't happen since the empty tuple is persistent */ 
        
           if (self->args == NULL) { 
        
               return NULL; 
        
           } 
        
           state->memerrors_freelist = (PyBaseExceptionObject *) self->dict; 
        
           state->memerrors_numfree--;

Most of the freelists were made thread-safe by making them per-thread in the free threaded build (using pycore_freelist.h), but we don't want to do that for MemoryError because its freelist serves a different purpose (it's not really for performance). I think we should just use a lock for MemoryError's freelist.

Linked PRs

pythongh-129668: Fix thread-safety of MemoryError freelist

gh-129668: Fix thread-safety of MemoryError freelist in free threaded…

pythongh-129668: Fix thread-safety of MemoryError freelist in free th…

[3.13] gh-129668: Fix thread-safety of MemoryError freelist in free t…

pythongh-129694: Add test_exceptions to parallel TSAN jobs

pythongh-129668: Fix thread-safety of MemoryError freelist in free th…

Navigation Menu

Repository navigation

MemoryError freelist is not thread-safe in free threaded build #129668

Bug report

Linked PRs

Metadata

Assignees

Labels

Projects

Milestone

Relationships

Development

	/* Fetch object from freelist and revive it */
	self = state->memerrors_freelist;
	self->args = PyTuple_New(0);
	/* This shouldn't happen since the empty tuple is persistent */

	if (self->args == NULL) {
	return NULL;
	}

	state->memerrors_freelist = (PyBaseExceptionObject *) self->dict;
	state->memerrors_numfree--;

MemoryError freelist is not thread-safe in free threaded build #129668

Description

Bug report

Linked PRs

Activity

Metadata

Metadata

Assignees

Labels

Projects

Milestone

Relationships

Development

Issue actions