typing.evaluate_forward_ref is not fully covered #128661

Activity

1. sobolevn

   added

   testsTests in the Lib/test dirTests in the Lib/test dir

   topic-typing

   3.14bugs and security fixesbugs and security fixes

   on Jan 9, 2025
2. sobolevn

   self-assigned this

   on Jan 9, 2025
3. sobolevn commented on Jan 9, 2025

   

   sobolevn

   on Jan 9, 2025

   MemberAuthor

   More actions

   Aaaand I found a bug!

   cpython/Lib/typing.py

   Lines 1021 to 1030 in a1284e9

   	def evaluate_forward_ref(
   	forward_ref,
   	*,
   	owner=None,
   	globals=None,
   	locals=None,
   	type_params=None,
   	format=annotationlib.Format.VALUE,
   	_recursive_guard=frozenset(),
   	):

   type_params here is None, not _sentinel, so the deprecation warning is never shown.

   🚀React with 🚀2Reacted by Tomas R. and Alex Waygood
4. sobolevn

   added 3 commits that reference this issue on Jan 9, 2025

   pythongh-128661: Fix `typing.evaluate_forward_ref` not showing deprec…

   ...

   120915a

   pythongh-128661: Fix `typing.evaluate_forward_ref` not showing deprec…

   ...

   17e7645

   gh-128661: Fix `typing.evaluate_forward_ref` not showing deprecation (#…

   ...

   b725297
5. sobolevn

   closed this as completedon Jan 9, 2025
6. JelleZijlstra

   added a commit that references this issue on Jan 17, 2025

   pythongh-128661: Remove DeprecationWarning in evaluate_forward_ref

   ...

   bc68f2e
7. JelleZijlstra

   added a commit that references this issue on Apr 3, 2025

   gh-128661: Remove DeprecationWarning in evaluate_forward_ref (#128930)

   ...

   5518c2a