Repository navigation
CONTAINS_OP can provide the operation name #123363
Description
Feature or enhancement
Proposal:
When referring to the in and not in operator, the dis module does not display in COMPARE_OP which operator is being used
>>> dis.dis('a in b')
0 0 RESUME 0
1 2 LOAD_NAME 0 (a)
4 LOAD_NAME 1 (b)
6 CONTAINS_OP 0
8 RETURN_VALUE
>>> dis.dis('a not in b')
0 0 RESUME 0
1 2 LOAD_NAME 0 (a)
4 LOAD_NAME 1 (b)
6 CONTAINS_OP 1
8 RETURN_VALUEBut if we look at the output of many other operators, we see explicit notation there:
>>> dis.dis('a + b')
0 0 RESUME 0
1 2 LOAD_NAME 0 (a)
4 LOAD_NAME 1 (b)
6 BINARY_OP 0 (+)
10 RETURN_VALUE
>>> dis.dis('a==b')
0 0 RESUME 0
1 2 LOAD_NAME 0 (a)
4 LOAD_NAME 1 (b)
6 COMPARE_OP 40 (==)
10 RETURN_VALUE
Has this already been discussed elsewhere?
No response given
Links to previous discussion of this feature:
No response
Activity
sobolevn commentedon Aug 27, 2024
Refs #123340
@Alexandr153 do you want to work on this? :)
I would be happy to help.
Alexandr153 commentedon Aug 27, 2024
Yes, I already tried to modify the module and it worked, but I think it is not the best option. I could look into the code in more detail, with your approval
sobolevn commentedon Aug 27, 2024
You can take a look at #123348 It does a very similar thing.
gh-123363: Show string value of CONTAINS_OP oparg in dis (#123387)