Repository navigation
_pyrepl.readline._ReadlineWrapper.get_line_buffer should return a str, not a bytes object #123228
Description
Bug report
Bug description:
_pyrepl.readline._ReadlineWrapper.get_line_buffer should return a str, not a bytes object, because readline.get_line_buffer also returns an str, not a bytes.
this has very little effect in CPython, but in PyPy it causes various problem, because we don't have a readline module at all, and use _pyrepl.readline instead.
I'm working on a PR.
CPython versions tested on:
3.13, CPython main branch
Operating systems tested on:
No response
Linked PRs
- gh-123228: fix return type for _ReadlineWrapper.get_line_buffer() #123281
- [3.13] gh-123228: fix return type for _ReadlineWrapper.get_line_buffer() (GH-123281) #123293
- gh-123228: don't leak file descriptors in pyrepl test #123302
- [3.13] gh-123228: don't leak file descriptors in pyrepl test (GH-123302) #123313
Activity
pythongh-123228: fix return type for _ReadlineWrapper.get_line_buffer()
skirpichev commentedon Aug 24, 2024
I took liberty to post a pr: #123281
gh-123228: fix return type for _ReadlineWrapper.get_line_buffer() (#1…
pythongh-123228: fix return type for _ReadlineWrapper.get_line_buffer…
[3.13] gh-123228: fix return type for _ReadlineWrapper.get_line_buffe…
cfbolz commentedon Aug 24, 2024
this is now fixed, thanks everyone!
cfbolz commentedon Aug 24, 2024
Ouch, there's a leaking file descriptor in the new test: #123281 (comment)
I know where, can fix it.
gh-123228: don't leak file descriptors in pyrepl test (#123302)
pythongh-123228: don't leak file descriptors in pyrepl test (pythonGH…
[3.13] gh-123228: don't leak file descriptors in pyrepl test (GH-123302…
cfbolz commentedon Aug 25, 2024
ok, hopefully we're actually done this time.