_sre.compile overwrites TypeError with OverflowError

Bug report

Reproduction:

>>> import _sre
>>> _sre.compile('', 0, ['abc'], 0, {}, ())
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
OverflowError: regular expression code size limit exceeded

It should be:

>>> import _sre
>>> _sre.compile('', 0, ['abc'], 0, {}, ())
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
TypeError: an integer is required

Because the third arg is code: object(subclass_of='&PyList_Type'), it is assumed to be integers inside.

Problematic lines:

cpython/Modules/_sre/sre.c

Lines 1510 to 1515 in def7ea5

    
           unsigned long value = PyLong_AsUnsignedLong(o); 
        
           self->code[i] = (SRE_CODE) value; 
        
           if ((unsigned long) self->code[i] != value) { 
        
               PyErr_SetString(PyExc_OverflowError, 
        
                               "regular expression code size limit exceeded"); 
        
               break;

They do not check for PyLong_AsUnsignedLong errors.
I have a PR ready :)

Linked PRs

pythongh-110590: Fix `_sre.compile` error overwrite

gh-110590: Fix a bug where _sre.compile would overwrite exceptions (#…

pythongh-110590: Fix a bug where _sre.compile would overwrite excepti…

[3.11] gh-110590: Fix a bug where _sre.compile would overwrite except…

[3.12] gh-110590: Fix a bug where _sre.compile would overwrite except…

pythongh-110590: Fix a bug where _sre.compile would overwrite excepti…

Navigation Menu

Repository navigation

`_sre.compile` overwrites `TypeError` with `OverflowError` #110590

Bug report

Linked PRs

Metadata

Assignees

Labels

Projects

Milestone

Relationships

Development

	unsigned long value = PyLong_AsUnsignedLong(o);
	self->code[i] = (SRE_CODE) value;
	if ((unsigned long) self->code[i] != value) {
	PyErr_SetString(PyExc_OverflowError,
	"regular expression code size limit exceeded");
	break;

_sre.compile overwrites TypeError with OverflowError #110590

Description

Bug report

Linked PRs

Activity

Metadata

Metadata

Assignees

Labels

Projects

Milestone

Relationships

Development

Issue actions

`_sre.compile` overwrites `TypeError` with `OverflowError` #110590