Skip to content

_testinternalcapi.get_counter_optimizer() segfaults #108727

Closed
#108734
Closed
_testinternalcapi.get_counter_optimizer() segfaults#108727
#108734
Assignees
markshannon
Labels
type-crashA hard crash of the interpreter, possibly with a core dump

Description

@iritkatriel
iritkatriel
opened on Aug 31, 2023

Crash report

CPython versions tested on:

CPython main branch

Operating systems tested on:

macOS

Output from running 'python -VV' on the command line:

Python 3.13.0a0 (heads/main:13a00078b8, Aug 31 2023, 18:44:11) [Clang 14.0.3 (clang-1403.0.22.14.1)]

What happened?

# cat zz.py                        
__lltrace__ = True

import _testinternalcapi

def f():
    _testinternalcapi.get_counter_optimizer()

f()

Error messages

% ./python.exe zz.py               

Resuming frame for 'f' in module '__main__'
    stack=[]
0: RESUME 0
    stack=[]
2: LOAD_GLOBAL 0
    stack=[<module at 0x1073f2150>]
12: LOAD_ATTR 2
    stack=[<builtin_function_or_method at 0x1073f3650>]
32: PUSH_NULL
    stack=[<builtin_function_or_method at 0x1073f3650>, <nil>]
34: CALL 0
    stack=[<Counter optimizer at 0x1073a47c0>]
42: POP_TOP
zsh: segmentation fault  ./python.exe zz.py

Linked PRs

Activity

  1. iritkatriel
    added
    type-crashA hard crash of the interpreter, possibly with a core dump
    on Aug 31, 2023
  2. iritkatriel
    assigned
    markshannon
    on Aug 31, 2023

  3. iritkatriel commented on Aug 31, 2023

    @iritkatriel
    iritkatriel
    on Aug 31, 2023
    MemberAuthor

    This seems to fix it:

    --- a/Python/optimizer.c
+++ b/Python/optimizer.c
@@ -289,6 +289,7 @@ static PyTypeObject CounterOptimizer_Type = {
     .tp_itemsize = 0,
     .tp_flags = Py_TPFLAGS_DEFAULT | Py_TPFLAGS_DISALLOW_INSTANTIATION,
     .tp_methods = counter_methods,
+    .tp_dealloc = (destructor)PyObject_Del,
 };
 
 PyObject *
  4. iritkatriel
    added a commit that references this issue on Aug 31, 2023

    pythongh-108727: Fix segfault due to missing tp_dealloc definition fo…

    33b1880
  5. markshannon
    closed this as completedin #108734on Sep 1, 2023
  6. markshannon
    added a commit that references this issue on Sep 1, 2023

    gh-108727: Fix segfault due to missing tp_dealloc definition for Coun…

    844f4c2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

type-crashA hard crash of the interpreter, possibly with a core dump

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions