Skip to content

perf(specifiers): push PEP 440 logic into the range engine - #1259

Merged
notatallshaw merged 2 commits into
pypa:mainfrom
notatallshaw:pep440-logic-to-ranges
Jun 15, 2026
Merged

notatallshaw merged 2 commits into
pypa:mainfrom
notatallshaw:pep440-logic-to-ranges

Conversation

@notatallshaw

Copy link
Copy Markdown
Member

Towards #1182

This pushes most of the special PEP 440 logic handling down into the range engine, so that VersionRange and SpecifierSet will share the same core logic.

@notatallshaw
notatallshaw force-pushed the pep440-logic-to-ranges branch from 3b3bac4 to 5a9b7f9 Compare June 13, 2026 17:41
@notatallshaw
notatallshaw force-pushed the pep440-logic-to-ranges branch from 5a9b7f9 to d6b0dc5 Compare June 13, 2026 17:45
@notatallshaw

notatallshaw commented Jun 13, 2026 •

Copy link
Copy Markdown
Member Author

This is ready for review.

I put a lot of effort into making sure no scenario significantly regressed in performance, even for a tradeoff of some scenarios significantly improving in performance.

I have achieved that, worst regression is only a few percent, I intend to keep these performance numbers for the public VersionRange API PR:

| Change   | Before [0b8f100b]    | After [6aa5517f]    |   Ratio | Benchmark (Parameter)                                                                                  |
|----------|----------------------|---------------------|---------|--------------------------------------------------------------------------------------------------------|
|          | 5.08Âą0.08ms          | 4.96Âą0.06ms         |    0.98 | markers.TimeMarkerSuite.time_constructor [runnervm1li68/virtualenv-py3.10-PYTHONHASHSEED0]             |
|          | 3.68Âą0.03ms          | 3.70Âą0.04ms         |    1    | markers.TimeMarkerSuite.time_constructor [runnervm1li68/virtualenv-py3.11-PYTHONHASHSEED0]             |
|          | 4.35Âą0.04ms          | 4.29Âą0.03ms         |    0.99 | markers.TimeMarkerSuite.time_constructor [runnervm1li68/virtualenv-py3.12-PYTHONHASHSEED0]             |
|          | 4.43Âą0.05ms          | 4.31Âą0.05ms         |    0.97 | markers.TimeMarkerSuite.time_constructor [runnervm1li68/virtualenv-py3.13-PYTHONHASHSEED0]             |
|          | 4.22Âą0.04ms          | 4.24Âą0.02ms         |    1.01 | markers.TimeMarkerSuite.time_constructor [runnervm1li68/virtualenv-py3.14-PYTHONHASHSEED0]             |
|          | 5.59Âą0.08ms          | 5.54Âą0.03ms         |    0.99 | markers.TimeMarkerSuite.time_constructor [runnervm1li68/virtualenv-py3.9-PYTHONHASHSEED0]              |
|          | 1.66Âą0.01ms          | 1.66Âą0.01ms         |    1    | markers.TimeMarkerSuite.time_evaluate [runnervm1li68/virtualenv-py3.10-PYTHONHASHSEED0]                |
|          | 1.09Âą0.01ms          | 1.09Âą0.01ms         |    1    | markers.TimeMarkerSuite.time_evaluate [runnervm1li68/virtualenv-py3.11-PYTHONHASHSEED0]                |
|          | 1.28Âą0.01ms          | 1.28Âą0.01ms         |    1    | markers.TimeMarkerSuite.time_evaluate [runnervm1li68/virtualenv-py3.12-PYTHONHASHSEED0]                |
|          | 1.15Âą0.01ms          | 1.16Âą0.01ms         |    1    | markers.TimeMarkerSuite.time_evaluate [runnervm1li68/virtualenv-py3.13-PYTHONHASHSEED0]                |
|          | 1.17Âą0.01ms          | 1.16Âą0.01ms         |    0.99 | markers.TimeMarkerSuite.time_evaluate [runnervm1li68/virtualenv-py3.14-PYTHONHASHSEED0]                |
|          | 1.67Âą0.08ms          | 1.66Âą0.02ms         |    1    | markers.TimeMarkerSuite.time_evaluate [runnervm1li68/virtualenv-py3.9-PYTHONHASHSEED0]                 |
|          | 16.2Âą0.2ms           | 16.0Âą0.08ms         |    0.98 | requirement.TimeRequirementSuite.time_constructor [runnervm1li68/virtualenv-py3.10-PYTHONHASHSEED0]    |
|          | 11.3Âą0.04ms          | 11.5Âą0.1ms          |    1.01 | requirement.TimeRequirementSuite.time_constructor [runnervm1li68/virtualenv-py3.11-PYTHONHASHSEED0]    |
|          | 13.5Âą0.1ms           | 13.3Âą0.05ms         |    0.99 | requirement.TimeRequirementSuite.time_constructor [runnervm1li68/virtualenv-py3.12-PYTHONHASHSEED0]    |
|          | 13.3Âą0.2ms           | 13.2Âą0.1ms          |    1    | requirement.TimeRequirementSuite.time_constructor [runnervm1li68/virtualenv-py3.13-PYTHONHASHSEED0]    |
|          | 12.5Âą0.1ms           | 12.7Âą0.2ms          |    1.01 | requirement.TimeRequirementSuite.time_constructor [runnervm1li68/virtualenv-py3.14-PYTHONHASHSEED0]    |
|          | 17.6Âą0.09ms          | 17.7Âą0.1ms          |    1.01 | requirement.TimeRequirementSuite.time_constructor [runnervm1li68/virtualenv-py3.9-PYTHONHASHSEED0]     |
|          | 613¹4Ξs              | 559¹3Ξs             |    0.91 | resolver.TimeResolverSuite.time_resolver_loop [runnervm1li68/virtualenv-py3.10-PYTHONHASHSEED0]        |
|          | 399¹2Ξs              | 365¹2Ξs             |    0.92 | resolver.TimeResolverSuite.time_resolver_loop [runnervm1li68/virtualenv-py3.11-PYTHONHASHSEED0]        |
| -        | 425¹1Ξs              | 379¹2Ξs             |    0.89 | resolver.TimeResolverSuite.time_resolver_loop [runnervm1li68/virtualenv-py3.12-PYTHONHASHSEED0]        |
| -        | 382¹3Ξs              | 344¹2Ξs             |    0.9  | resolver.TimeResolverSuite.time_resolver_loop [runnervm1li68/virtualenv-py3.13-PYTHONHASHSEED0]        |
| -        | 367¹5Ξs              | 324¹3Ξs             |    0.88 | resolver.TimeResolverSuite.time_resolver_loop [runnervm1li68/virtualenv-py3.14-PYTHONHASHSEED0]        |
|          | 676¹6Ξs              | 618¹1Ξs             |    0.91 | resolver.TimeResolverSuite.time_resolver_loop [runnervm1li68/virtualenv-py3.9-PYTHONHASHSEED0]         |
|          | 2.29Âą0.02ms          | 2.27Âą0.01ms         |    0.99 | specifiers.TimeSpecSuite.time_constructor [runnervm1li68/virtualenv-py3.10-PYTHONHASHSEED0]            |
|          | 1.90Âą0.03ms          | 1.89Âą0.01ms         |    1    | specifiers.TimeSpecSuite.time_constructor [runnervm1li68/virtualenv-py3.11-PYTHONHASHSEED0]            |
|          | 2.13Âą0.02ms          | 2.13Âą0.01ms         |    1    | specifiers.TimeSpecSuite.time_constructor [runnervm1li68/virtualenv-py3.12-PYTHONHASHSEED0]            |
|          | 1.88Âą0.02ms          | 1.86Âą0.02ms         |    0.99 | specifiers.TimeSpecSuite.time_constructor [runnervm1li68/virtualenv-py3.13-PYTHONHASHSEED0]            |
|          | 1.83Âą0.01ms          | 1.83Âą0.01ms         |    1    | specifiers.TimeSpecSuite.time_constructor [runnervm1li68/virtualenv-py3.14-PYTHONHASHSEED0]            |
|          | 2.24Âą0.01ms          | 2.24Âą0.02ms         |    1    | specifiers.TimeSpecSuite.time_constructor [runnervm1li68/virtualenv-py3.9-PYTHONHASHSEED0]             |
|          | 7.86Âą0.05ms          | 7.64Âą0.03ms         |    0.97 | specifiers.TimeSpecSuite.time_contains_cold [runnervm1li68/virtualenv-py3.10-PYTHONHASHSEED0]          |
|          | 5.01Âą0.03ms          | 4.91Âą0.02ms         |    0.98 | specifiers.TimeSpecSuite.time_contains_cold [runnervm1li68/virtualenv-py3.11-PYTHONHASHSEED0]          |
|          | 5.74Âą0.04ms          | 5.56Âą0.04ms         |    0.97 | specifiers.TimeSpecSuite.time_contains_cold [runnervm1li68/virtualenv-py3.12-PYTHONHASHSEED0]          |
|          | 5.19Âą0.03ms          | 5.06Âą0.08ms         |    0.97 | specifiers.TimeSpecSuite.time_contains_cold [runnervm1li68/virtualenv-py3.13-PYTHONHASHSEED0]          |
|          | 4.90Âą0.04ms          | 4.74Âą0.04ms         |    0.97 | specifiers.TimeSpecSuite.time_contains_cold [runnervm1li68/virtualenv-py3.14-PYTHONHASHSEED0]          |
|          | 8.64Âą0.04ms          | 8.38Âą0.03ms         |    0.97 | specifiers.TimeSpecSuite.time_contains_cold [runnervm1li68/virtualenv-py3.9-PYTHONHASHSEED0]           |
| -        | 499¹4Ξs              | 117¹0.7Ξs           |    0.24 | specifiers.TimeSpecSuite.time_contains_complex_warm [runnervm1li68/virtualenv-py3.10-PYTHONHASHSEED0]  |
| -        | 326¹2Ξs              | 79.3¹0.9Ξs          |    0.24 | specifiers.TimeSpecSuite.time_contains_complex_warm [runnervm1li68/virtualenv-py3.11-PYTHONHASHSEED0]  |
| -        | 314¹2Ξs              | 70.6¹2Ξs            |    0.23 | specifiers.TimeSpecSuite.time_contains_complex_warm [runnervm1li68/virtualenv-py3.12-PYTHONHASHSEED0]  |
| -        | 307¹2Ξs              | 70.4¹0.7Ξs          |    0.23 | specifiers.TimeSpecSuite.time_contains_complex_warm [runnervm1li68/virtualenv-py3.13-PYTHONHASHSEED0]  |
| -        | 298¹2Ξs              | 66.7¹0.9Ξs          |    0.22 | specifiers.TimeSpecSuite.time_contains_complex_warm [runnervm1li68/virtualenv-py3.14-PYTHONHASHSEED0]  |
| -        | 575¹5Ξs              | 146¹2Ξs             |    0.25 | specifiers.TimeSpecSuite.time_contains_complex_warm [runnervm1li68/virtualenv-py3.9-PYTHONHASHSEED0]   |
| -        | 1.59Âą0.01ms          | 1.31Âą0.01ms         |    0.82 | specifiers.TimeSpecSuite.time_contains_warm [runnervm1li68/virtualenv-py3.10-PYTHONHASHSEED0]          |
| -        | 990¹10Ξs             | 793¹7Ξs             |    0.8  | specifiers.TimeSpecSuite.time_contains_warm [runnervm1li68/virtualenv-py3.11-PYTHONHASHSEED0]          |
| -        | 969¹20Ξs             | 750¹4Ξs             |    0.77 | specifiers.TimeSpecSuite.time_contains_warm [runnervm1li68/virtualenv-py3.12-PYTHONHASHSEED0]          |
| -        | 867¹6Ξs              | 687¹9Ξs             |    0.79 | specifiers.TimeSpecSuite.time_contains_warm [runnervm1li68/virtualenv-py3.13-PYTHONHASHSEED0]          |
| -        | 816¹3Ξs              | 608¹6Ξs             |    0.74 | specifiers.TimeSpecSuite.time_contains_warm [runnervm1li68/virtualenv-py3.14-PYTHONHASHSEED0]          |
| -        | 1.87Âą0.05ms          | 1.52Âą0.01ms         |    0.81 | specifiers.TimeSpecSuite.time_contains_warm [runnervm1li68/virtualenv-py3.9-PYTHONHASHSEED0]           |
|          | 69.6¹2Ξs             | 69.5¹0.6Ξs          |    1    | specifiers.TimeSpecSuite.time_filter_compatible_warm [runnervm1li68/virtualenv-py3.10-PYTHONHASHSEED0] |
|          | 45.3¹0.4Ξs           | 45.1¹0.4Ξs          |    1    | specifiers.TimeSpecSuite.time_filter_compatible_warm [runnervm1li68/virtualenv-py3.11-PYTHONHASHSEED0] |
|          | 43.5¹0.2Ξs           | 43.8¹0.4Ξs          |    1.01 | specifiers.TimeSpecSuite.time_filter_compatible_warm [runnervm1li68/virtualenv-py3.12-PYTHONHASHSEED0] |
|          | 43.2¹0.2Ξs           | 42.9¹0.2Ξs          |    0.99 | specifiers.TimeSpecSuite.time_filter_compatible_warm [runnervm1li68/virtualenv-py3.13-PYTHONHASHSEED0] |
|          | 43.8¹0.4Ξs           | 42.9¹0.4Ξs          |    0.98 | specifiers.TimeSpecSuite.time_filter_compatible_warm [runnervm1li68/virtualenv-py3.14-PYTHONHASHSEED0] |
|          | 77.7¹2Ξs             | 78.3¹1Ξs            |    1.01 | specifiers.TimeSpecSuite.time_filter_compatible_warm [runnervm1li68/virtualenv-py3.9-PYTHONHASHSEED0]  |
|          | 164¹0.6Ξs            | 168¹1Ξs             |    1.03 | specifiers.TimeSpecSuite.time_filter_complex_cold [runnervm1li68/virtualenv-py3.10-PYTHONHASHSEED0]    |
|          | 107¹0.7Ξs            | 109¹0.4Ξs           |    1.01 | specifiers.TimeSpecSuite.time_filter_complex_cold [runnervm1li68/virtualenv-py3.11-PYTHONHASHSEED0]    |
|          | 120¹1Ξs              | 120¹0.7Ξs           |    1    | specifiers.TimeSpecSuite.time_filter_complex_cold [runnervm1li68/virtualenv-py3.12-PYTHONHASHSEED0]    |
|          | 113¹0.7Ξs            | 115¹1Ξs             |    1.02 | specifiers.TimeSpecSuite.time_filter_complex_cold [runnervm1li68/virtualenv-py3.13-PYTHONHASHSEED0]    |
|          | 110¹0.9Ξs            | 111¹0.8Ξs           |    1    | specifiers.TimeSpecSuite.time_filter_complex_cold [runnervm1li68/virtualenv-py3.14-PYTHONHASHSEED0]    |
|          | 187¹3Ξs              | 188¹0.9Ξs           |    1    | specifiers.TimeSpecSuite.time_filter_complex_cold [runnervm1li68/virtualenv-py3.9-PYTHONHASHSEED0]     |
|          | 55.5¹0.5Ξs           | 54.9¹0.5Ξs          |    0.99 | specifiers.TimeSpecSuite.time_filter_complex_warm [runnervm1li68/virtualenv-py3.10-PYTHONHASHSEED0]    |
|          | 35.4¹0.2Ξs           | 35.3¹0.5Ξs          |    1    | specifiers.TimeSpecSuite.time_filter_complex_warm [runnervm1li68/virtualenv-py3.11-PYTHONHASHSEED0]    |
|          | 37.8¹0.2Ξs           | 37.9¹0.5Ξs          |    1    | specifiers.TimeSpecSuite.time_filter_complex_warm [runnervm1li68/virtualenv-py3.12-PYTHONHASHSEED0]    |
|          | 38.5¹0.2Ξs           | 38.3¹0.2Ξs          |    0.99 | specifiers.TimeSpecSuite.time_filter_complex_warm [runnervm1li68/virtualenv-py3.13-PYTHONHASHSEED0]    |
|          | 39.6¹0.6Ξs           | 37.9¹0.4Ξs          |    0.95 | specifiers.TimeSpecSuite.time_filter_complex_warm [runnervm1li68/virtualenv-py3.14-PYTHONHASHSEED0]    |
|          | 64.9¹1Ξs             | 64.6¹0.8Ξs          |    0.99 | specifiers.TimeSpecSuite.time_filter_complex_warm [runnervm1li68/virtualenv-py3.9-PYTHONHASHSEED0]     |
|          | 16.4¹0.09Ξs          | 16.8¹0.05Ξs         |    1.02 | specifiers.TimeSpecSuite.time_filter_simple_cold [runnervm1li68/virtualenv-py3.10-PYTHONHASHSEED0]     |
|          | 10.5¹0.05Ξs          | 11.0¹0.2Ξs          |    1.05 | specifiers.TimeSpecSuite.time_filter_simple_cold [runnervm1li68/virtualenv-py3.11-PYTHONHASHSEED0]     |
|          | 10.2¹0.04Ξs          | 10.5¹0.05Ξs         |    1.04 | specifiers.TimeSpecSuite.time_filter_simple_cold [runnervm1li68/virtualenv-py3.12-PYTHONHASHSEED0]     |
|          | 9.66¹0.07Ξs          | 10.0¹0.1Ξs          |    1.04 | specifiers.TimeSpecSuite.time_filter_simple_cold [runnervm1li68/virtualenv-py3.13-PYTHONHASHSEED0]     |
|          | 9.90¹0.04Ξs          | 10.3¹0.06Ξs         |    1.04 | specifiers.TimeSpecSuite.time_filter_simple_cold [runnervm1li68/virtualenv-py3.14-PYTHONHASHSEED0]     |
|          | 17.6¹0.2Ξs           | 18.4¹0.1Ξs          |    1.04 | specifiers.TimeSpecSuite.time_filter_simple_cold [runnervm1li68/virtualenv-py3.9-PYTHONHASHSEED0]      |
|          | 8.79¹0.08Ξs          | 8.88¹0.05Ξs         |    1.01 | specifiers.TimeSpecSuite.time_filter_simple_warm [runnervm1li68/virtualenv-py3.10-PYTHONHASHSEED0]     |
|          | 5.74¹0.06Ξs          | 5.75¹0.03Ξs         |    1    | specifiers.TimeSpecSuite.time_filter_simple_warm [runnervm1li68/virtualenv-py3.11-PYTHONHASHSEED0]     |
|          | 5.29¹0.04Ξs          | 5.27¹0.03Ξs         |    1    | specifiers.TimeSpecSuite.time_filter_simple_warm [runnervm1li68/virtualenv-py3.12-PYTHONHASHSEED0]     |
|          | 5.21¹0.07Ξs          | 5.22¹0.06Ξs         |    1    | specifiers.TimeSpecSuite.time_filter_simple_warm [runnervm1li68/virtualenv-py3.13-PYTHONHASHSEED0]     |
|          | 5.40¹0.05Ξs          | 5.29¹0.05Ξs         |    0.98 | specifiers.TimeSpecSuite.time_filter_simple_warm [runnervm1li68/virtualenv-py3.14-PYTHONHASHSEED0]     |
|          | 9.89¹0.2Ξs           | 9.84¹0.09Ξs         |    1    | specifiers.TimeSpecSuite.time_filter_simple_warm [runnervm1li68/virtualenv-py3.9-PYTHONHASHSEED0]      |
|          | 4.84¹0.05Ξs          | 4.87¹0.04Ξs         |    1.01 | utils.TimeUtils.time_canonicalize_name [runnervm1li68/virtualenv-py3.10-PYTHONHASHSEED0]               |
|          | 3.48¹0.04Ξs          | 3.45¹0.04Ξs         |    0.99 | utils.TimeUtils.time_canonicalize_name [runnervm1li68/virtualenv-py3.11-PYTHONHASHSEED0]               |
|          | 3.58¹0.03Ξs          | 3.59¹0.09Ξs         |    1    | utils.TimeUtils.time_canonicalize_name [runnervm1li68/virtualenv-py3.12-PYTHONHASHSEED0]               |
|          | 3.70¹0.02Ξs          | 3.67¹0.04Ξs         |    0.99 | utils.TimeUtils.time_canonicalize_name [runnervm1li68/virtualenv-py3.13-PYTHONHASHSEED0]               |
|          | 3.80¹0.02Ξs          | 3.78¹0.02Ξs         |    1    | utils.TimeUtils.time_canonicalize_name [runnervm1li68/virtualenv-py3.14-PYTHONHASHSEED0]               |
|          | 5.14¹0.1Ξs           | 5.15¹0.1Ξs          |    1    | utils.TimeUtils.time_canonicalize_name [runnervm1li68/virtualenv-py3.9-PYTHONHASHSEED0]                |
|          | 2.68Âą0.04ms          | 2.71Âą0.04ms         |    1.01 | version.TimeVersionSuite.time_constructor [runnervm1li68/virtualenv-py3.10-PYTHONHASHSEED0]            |
|          | 1.66Âą0.02ms          | 1.66Âą0.02ms         |    1    | version.TimeVersionSuite.time_constructor [runnervm1li68/virtualenv-py3.11-PYTHONHASHSEED0]            |
|          | 2.14Âą0.02ms          | 2.16Âą0.03ms         |    1.01 | version.TimeVersionSuite.time_constructor [runnervm1li68/virtualenv-py3.12-PYTHONHASHSEED0]            |
|          | 1.90Âą0.03ms          | 1.94Âą0.02ms         |    1.02 | version.TimeVersionSuite.time_constructor [runnervm1li68/virtualenv-py3.13-PYTHONHASHSEED0]            |
|          | 1.69Âą0.03ms          | 1.69Âą0.02ms         |    1    | version.TimeVersionSuite.time_constructor [runnervm1li68/virtualenv-py3.14-PYTHONHASHSEED0]            |
|          | 2.75Âą0.04ms          | 2.70Âą0.01ms         |    0.98 | version.TimeVersionSuite.time_constructor [runnervm1li68/virtualenv-py3.9-PYTHONHASHSEED0]             |
|          | 3.53Âą0.02ms          | 3.54Âą0.01ms         |    1    | version.TimeVersionSuite.time_hash [runnervm1li68/virtualenv-py3.10-PYTHONHASHSEED0]                   |
|          | 2.29Âą0.01ms          | 2.30Âą0.01ms         |    1    | version.TimeVersionSuite.time_hash [runnervm1li68/virtualenv-py3.11-PYTHONHASHSEED0]                   |
|          | 2.87Âą0.01ms          | 2.86Âą0.02ms         |    1    | version.TimeVersionSuite.time_hash [runnervm1li68/virtualenv-py3.12-PYTHONHASHSEED0]                   |
|          | 2.61Âą0.01ms          | 2.63Âą0.02ms         |    1.01 | version.TimeVersionSuite.time_hash [runnervm1li68/virtualenv-py3.13-PYTHONHASHSEED0]                   |
|          | 2.36Âą0.03ms          | 2.33Âą0.01ms         |    0.99 | version.TimeVersionSuite.time_hash [runnervm1li68/virtualenv-py3.14-PYTHONHASHSEED0]                   |
|          | 3.77Âą0.03ms          | 3.77Âą0.02ms         |    1    | version.TimeVersionSuite.time_hash [runnervm1li68/virtualenv-py3.9-PYTHONHASHSEED0]                    |
|          | 163¹2Ξs              | 164¹1Ξs             |    1    | version.TimeVersionSuite.time_hash_warm [runnervm1li68/virtualenv-py3.10-PYTHONHASHSEED0]              |
|          | 106¹0.9Ξs            | 104¹1Ξs             |    0.99 | version.TimeVersionSuite.time_hash_warm [runnervm1li68/virtualenv-py3.11-PYTHONHASHSEED0]              |
|          | 134¹0.8Ξs            | 133¹0.8Ξs           |    1    | version.TimeVersionSuite.time_hash_warm [runnervm1li68/virtualenv-py3.12-PYTHONHASHSEED0]              |
|          | 130¹1Ξs              | 128¹1Ξs             |    0.98 | version.TimeVersionSuite.time_hash_warm [runnervm1li68/virtualenv-py3.13-PYTHONHASHSEED0]              |
|          | 134¹2Ξs              | 134¹0.6Ξs           |    1    | version.TimeVersionSuite.time_hash_warm [runnervm1li68/virtualenv-py3.14-PYTHONHASHSEED0]              |
|          | 186¹0.9Ξs            | 184¹1Ξs             |    0.99 | version.TimeVersionSuite.time_hash_warm [runnervm1li68/virtualenv-py3.9-PYTHONHASHSEED0]               |
|          | 2.69Âą0.02ms          | 2.73Âą0.05ms         |    1.01 | version.TimeVersionSuite.time_sort_cold [runnervm1li68/virtualenv-py3.10-PYTHONHASHSEED0]              |
|          | 1.93Âą0.03ms          | 1.90Âą0.01ms         |    0.99 | version.TimeVersionSuite.time_sort_cold [runnervm1li68/virtualenv-py3.11-PYTHONHASHSEED0]              |
|          | 2.26Âą0.02ms          | 2.23Âą0.02ms         |    0.99 | version.TimeVersionSuite.time_sort_cold [runnervm1li68/virtualenv-py3.12-PYTHONHASHSEED0]              |
|          | 2.29Âą0.02ms          | 2.29Âą0.02ms         |    1    | version.TimeVersionSuite.time_sort_cold [runnervm1li68/virtualenv-py3.13-PYTHONHASHSEED0]              |
|          | 2.21Âą0.01ms          | 2.22Âą0.02ms         |    1.01 | version.TimeVersionSuite.time_sort_cold [runnervm1li68/virtualenv-py3.14-PYTHONHASHSEED0]              |
|          | 3.36Âą0.02ms          | 3.32Âą0.03ms         |    0.99 | version.TimeVersionSuite.time_sort_cold [runnervm1li68/virtualenv-py3.9-PYTHONHASHSEED0]               |
|          | 2.06Âą0.02ms          | 2.06Âą0.02ms         |    1    | version.TimeVersionSuite.time_sort_warm [runnervm1li68/virtualenv-py3.10-PYTHONHASHSEED0]              |
|          | 1.53Âą0.02ms          | 1.53Âą0.02ms         |    1    | version.TimeVersionSuite.time_sort_warm [runnervm1li68/virtualenv-py3.11-PYTHONHASHSEED0]              |
|          | 1.82Âą0.01ms          | 1.83Âą0.02ms         |    1.01 | version.TimeVersionSuite.time_sort_warm [runnervm1li68/virtualenv-py3.12-PYTHONHASHSEED0]              |
|          | 1.84Âą0.03ms          | 1.86Âą0.02ms         |    1.01 | version.TimeVersionSuite.time_sort_warm [runnervm1li68/virtualenv-py3.13-PYTHONHASHSEED0]              |
|          | 1.83Âą0.01ms          | 1.81Âą0.02ms         |    0.99 | version.TimeVersionSuite.time_sort_warm [runnervm1li68/virtualenv-py3.14-PYTHONHASHSEED0]              |
|          | 2.58Âą0.03ms          | 2.53Âą0.01ms         |    0.98 | version.TimeVersionSuite.time_sort_warm [runnervm1li68/virtualenv-py3.9-PYTHONHASHSEED0]               |
|          | 4.37Âą0.02ms          | 4.39Âą0.02ms         |    1.01 | version.TimeVersionSuite.time_str [runnervm1li68/virtualenv-py3.10-PYTHONHASHSEED0]                    |
|          | 3.03Âą0.02ms          | 3.03Âą0.02ms         |    1    | version.TimeVersionSuite.time_str [runnervm1li68/virtualenv-py3.11-PYTHONHASHSEED0]                    |
|          | 3.54Âą0.02ms          | 3.57Âą0.03ms         |    1.01 | version.TimeVersionSuite.time_str [runnervm1li68/virtualenv-py3.12-PYTHONHASHSEED0]                    |
|          | 3.07Âą0.03ms          | 3.11Âą0.03ms         |    1.01 | version.TimeVersionSuite.time_str [runnervm1li68/virtualenv-py3.13-PYTHONHASHSEED0]                    |
|          | 2.96Âą0.03ms          | 2.98Âą0.02ms         |    1.01 | version.TimeVersionSuite.time_str [runnervm1li68/virtualenv-py3.14-PYTHONHASHSEED0]                    |
|          | 4.72Âą0.08ms          | 4.76Âą0.03ms         |    1.01 | version.TimeVersionSuite.time_str [runnervm1li68/virtualenv-py3.9-PYTHONHASHSEED0]                     |

SOME BENCHMARKS HAVE CHANGED SIGNIFICANTLY.
PERFORMANCE INCREASED.

@notatallshaw
notatallshaw marked this pull request as ready for review June 13, 2026 17:53
@notatallshaw notatallshaw changed the title Push PEP 440 logic into the range engine perf(specifiers): push PEP 440 logic into the range engine Jun 14, 2026

@henryiii henryiii left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I ran Kimi K2.7 code on it for review, it didn't find anything.

ðŸĪ– Kimi K2.7-code review

The review completed with no bugs found and a recommendation to approve.

Key points:

  • The refactor in specifiers.py / _ranges.py is internally consistent.
  • resolve_prereleases is behaviorally equivalent to the previous inline logic.
  • coerce_version going from private to internal-public is acceptable since _ranges.py is still private to the package.
  • bounds_for_spec correctly leaves === handling to callers.
  • One test mutates ss._ranges = () as a white-box “poisoning” check; that’s intentional but couples the test to internal state.
  • Minor nit: the test name test_specifierset_contains_reads_cached_bounds is slightly misleading because contains tries _fast_match before falling back to cached bounds.

No code changes are required unless you want to rename that test. Let me know if you’d like me to do that.

This looks good to me.

@notatallshaw
notatallshaw merged commit 664f049 into pypa:main Jun 15, 2026
59 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants