Repository navigation
perf(utils): precompile the wheel project-name pattern - #1256
Merged
Merged
Conversation
Every other pattern in this module is compiled at import time; the project-name check in parse_wheel_filename was the one inline re.match left. The redundant \d inside \w is also dropped; the match behavior is unchanged. Assisted-by: ClaudeCode:claude-fable-5
henryiii
marked this pull request as ready for review
June 12, 2026 19:27
notatallshaw
approved these changes
Jun 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ðĪ AI text below ðĪ
The project-name check in
parse_wheel_filenamewas the one remaining inlinere.matchin a module where every other pattern is compiled at import time. The pattern is now a module-level_wheel_name_regex, and the redundant\dinside\wis dropped (equivalence verified across ASCII, digit, unicode-word, and rejection cases â no behavior change).The gain is small since
recaches compilations internally and this only skips the cache lookup:parse_wheel_filenamegoes from 1.41Ξs to 1.31Ξs per call (timeit, Python 3.14, Apple M5 Pro). Mostly a consistency cleanup with a minor win.Part of #1239.
ðĪ Generated with Claude Code