Repository navigation
Leave non-plain style objects untouched in compat - #5318
Merged
Merged
Conversation
📊 Tachometer Benchmark ResultsSummaryduration
usedJSHeapSize
Resultscreate10kduration
usedJSHeapSize
filter-listduration
usedJSHeapSize
hydrate1kduration
usedJSHeapSize
many-updatesduration
usedJSHeapSize
replace1kduration
usedJSHeapSize
run-warmup-0
run-warmup-1
run-warmup-2
run-warmup-3
run-warmup-4
run-final
text-updateduration
usedJSHeapSize
tododuration
usedJSHeapSize
update10th1kduration
usedJSHeapSize
|
|
Size Change: +4 B (+0.02%) Total Size: 16.3 kB 📦 View Changed
ℹ️ View Unchanged
|
|
coverage: 99.857%. remained the same — JoviDeCroock/compat-signal-style into main |
marvinhagemeister
approved these changes
Oct 20, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Compat treated any object `style` as a style map and cloned it to append `px`. A signal has numeric internals (`_version`, `_batchSnapshotVersion`), so `style={signal}` was copied into a plain object like `{ v: 'color: red', i: '0px' }`. `@preact/signals` then no longer recognised it, so the element rendered without a style, for both string and object signals.
Compat now only appends `px` to plain objects. +2 B gzip in compat.
With this change, string signals work in compat as they do in core. Updating an object signal still wipes the style. That bug is in `@preact/signals`, which sets `dom.style = obj`, and it happens in core too, so it needs a separate fix there.
Note
Authored by claude.