Repository navigation
Fix scrollable padding - #1466
Conversation
1f3e533 to
7e6c597
Compare
|
I don't think this is the correct approach since it works around the issue and requires applications to manually call this workaround in their application. Padding issues with the main content area should be worked out internally with the widgets. The |
|
Apps already manually do their content padding. This would just ensure the padding follows designs and devs don't need to know the logic.
Maybe I misunderstand this, but |
|
It's already not ideal that applications are manually applying padding so it would not be ideal to make this workaround a standardized requirement. The application view is already managing padding for thresholds as needed to compensate for the navbar behavior (condensed and collapsed) so we shouldn't need a second layer that applications have to manually apply on top of that. |
|
I've moved the padding method to a different branch so it can be used as a reference in the future with the new scrollable container widget. |
|
@mmstick (sorry for the ping), can this maybe be merged to fix the regression (that I caused ð )? |
Fixes vertical scrollable padding, since
.direction()overrides the padding set before it.