Skip to content

fix: accumulate fractional wheel-line scroll deltas - #861

Merged
jacobgkau merged 2 commits into
pop-os:masterfrom
FreddyFunk:fix-hires-wheel-scroll
Jun 30, 2026
Merged

jacobgkau merged 2 commits into
pop-os:masterfrom
FreddyFunk:fix-hires-wheel-scroll

Conversation

@FreddyFunk

Copy link
Copy Markdown
Contributor

This fixes completely broken scrolling with my Logitech G502 X mouse.

  • I have disclosed use of any AI generated code in my commit messages.
    • If you are using an LLM, and do not fully understand the changes it is making to the code base, do not create a PR.
    • In our experience, AI generated code often results in overly complex code that lacks enough context for a proper fix or feature inclusion. This results in considerably longer code reviews. Due to this, AI authored or partially authored PRs may be closed without comment.
  • I understand these changes in full and will be able to respond to review comments.
  • My change is accurately described in the commit message.
  • My contribution is tested and working as described.
  • I have read the Developer Certificate of Origin and certify my contribution under its conditions.

@jackpot51
jackpot51 requested a review from a team June 30, 2026 22:16
@jacobgkau jacobgkau self-assigned this Jun 30, 2026

@jacobgkau jacobgkau left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we have a fractional-scrolling mouse around to test with (or else we would've noticed this was broken). However, scrolling still works fine with a touchpad and a regular mouse scrollwheel.

I did my normal regression testing of all menu items; not seeing any problems.

@jacobgkau
jacobgkau merged commit 1e49511 into pop-os:master Jun 30, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants