Skip to content

Load all installed apps icons - #572

Merged
jacobgkau merged 1 commit into
pop-os:masterfrom
hojjatabdollahi:hojjat/load-icons
Oct 1, 2026
Merged

jacobgkau merged 1 commit into
pop-os:masterfrom
hojjatabdollahi:hojjat/load-icons

Conversation

@hojjatabdollahi

@hojjatabdollahi hojjatabdollahi commented Jul 13, 2026 •

Copy link
Copy Markdown
Contributor

Only the first 100 installed apps have icons.

image

I also ran cargo fmt and cargo clippy --fix as a separate commit. I can drop it if you want.


  • I have disclosed use of any AI generated code in my commit messages.
    • If you are using an LLM, and do not fully understand the changes it is making to the code base, do not create a PR.
    • In our experience, AI generated code often results in overly complex code that lacks enough context for a proper fix or feature inclusion. This results in considerably longer code reviews. Due to this, AI authored or partially authored PRs may be closed without comment.
  • I understand these changes in full and will be able to respond to review comments.
  • My change is accurately described in the commit message.
  • My contribution is tested and working as described.
  • I have read the Developer Certificate of Origin and certify my contribution under its conditions.

@jackpot51
jackpot51 requested review from a team September 30, 2026 18:23
@jklgrasso

Copy link
Copy Markdown

Please resolve the conflicts when you're able

@jklgrasso jklgrasso self-assigned this Oct 1, 2026

@jklgrasso jklgrasso left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Application icons load as expected.

Regression testing passed

Checklist

  • Able to install & remove a Flatpak app.
  • Able to install & remove a Deb app.
  • Able to install Deb updates.
  • Searching still works.
  • Browsing categories still works.
  • Able to remove & re-add Flatpak sources.

@jacobgkau
jacobgkau merged commit 178dd94 into pop-os:master Oct 1, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants