Repository navigation
Conversation
Are the three dots in the upper-left of the OSK supposed to do anything? It looks like it's supposed to be a menu, but clicking it does nothing. (Testing with OSK version 0a3996d.) 
|
Yes, it is for a menu, which I will finish soon |
|
Work on the menus is here, I will try to finish tomorrow: pop-os/cosmic-osk#32 |
|
@jacobgkau the menus were implemented, so the next build of cosmic-osk will have them |
|
Similar to what I reported for the greeter in pop-os/cosmic-greeter#545 (review), I'm seeing the OSK automatically pop up after login on a normal laptop after installing this branch (on a completely fresh install). This would be a bit disruptive to our existing userbase. 
|
|
@jacobgkau what version of cosmic-osk do you have? In settings, do you have the always show toggle on already? It should default to off in https://github.com/pop-os/cosmic-osk/blob/master/config/src/lib.rs#L54 |
|
@jackpot51 I see, I had version 0a859e3 from release. After adding master and updating it to d7b66a2, it seems it defaults to off as expected. |
jacobgkau
left a comment
jacobgkau
left a comment
There was a problem hiding this comment.
The OSK auto-start for usage with the applet, its settings, etc. is working as expected. The OSK itself is in a shippable state.
This applet will toggle the OSK, once pop-os/cosmic-session#227 is merged --- - [x] I have disclosed use of any AI generated code in my commit messages. - If you are using an LLM, and do not fully understand the changes it is making to the code base, do not create a PR. - In our experience, AI generated code often results in overly complex code that lacks enough context for a proper fix or feature inclusion. This results in considerably longer code reviews. Due to this, AI authored or partially authored PRs may be closed without comment. - [x] I understand these changes in full and will be able to respond to review comments. - [x] My change is accurately described in the commit message. - [x] My contribution is tested and working as described. - [x] I have read the [Developer Certificate of Origin](https://developercertificate.org/) and certify my contribution under its conditions.
This will auto-start the OSK, for use by pop-os/cosmic-settings#2201. The OSK itself should be evaluated before merging this.