Repository navigation
Fix malformed MP4 playback timing - #294
Merged
Merged
Conversation
mmstick
requested changes
Jul 2, 2026
krakotay
marked this pull request as draft
July 3, 2026 05:51
krakotay
marked this pull request as ready for review
August 26, 2026 16:42
Contributor
Author
|
@mmstick due to wash2/iced_video_player#3 merged, the PR is ready for review now |
leviport
approved these changes
Aug 28, 2026
leviport
left a comment
Member
There was a problem hiding this comment.
Regression testing passed:
File Operations
- Selecting a folder with Open media folder opens the directory in the folder pane
- Selecting media from the folder pane works
- Open recent media contains a list of recently opened media
Navigation
- A-B repeat works with video and audio files
- A-B frame stepping works in video files
- General media navigation keybinds work and correctly update the timestamp where applicable
wash2
approved these changes
Aug 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some videos on my PC, like this one, previously wouldn't play:
https://github.com/user-attachments/assets/b329351b-a947-4f67-944c-ad53c6aa6894
Other videos suffered from severe audio playback issues. Both problems are now fixed.
Some malformed MP4 files previously wouldn't play at all because they reported a 0/1 framerate.
Other files suffered from severe audio stuttering caused by repeated long GAP events emitted from malformed edit lists.
This patch treats invalid framerates as unknown (allowing the existing fallback to be used) and suppresses suspicious long audio GAP events before they reach the audio sink.
As a result, both kinds of videos now play correctly.