Skip to content

Fix malformed MP4 playback timing - #294

Merged
mmstick merged 4 commits into
pop-os:masterfrom
krakotay:fix-video-playing
Aug 29, 2026
Merged

mmstick merged 4 commits into
pop-os:masterfrom
krakotay:fix-video-playing

Conversation

@krakotay

@krakotay krakotay commented Jul 2, 2026

Copy link
Copy Markdown
Contributor
  • I have disclosed use of any AI generated code in my commit messages.
    • If you are using an LLM, and do not fully understand the changes it is making to the code base, do not create a PR.
    • In our experience, AI generated code often results in overly complex code that lacks enough context for a proper fix or feature inclusion. This results in considerably longer code reviews. Due to this, AI authored or partially authored PRs may be closed without comment.
  • I understand these changes in full and will be able to respond to review comments.
  • My change is accurately described in the commit message.
  • My contribution is tested and working as described.
  • I have read the Developer Certificate of Origin and certify my contribution under its conditions.

Some videos on my PC, like this one, previously wouldn't play:
https://github.com/user-attachments/assets/b329351b-a947-4f67-944c-ad53c6aa6894
Other videos suffered from severe audio playback issues. Both problems are now fixed.
Some malformed MP4 files previously wouldn't play at all because they reported a 0/1 framerate.
Other files suffered from severe audio stuttering caused by repeated long GAP events emitted from malformed edit lists.
This patch treats invalid framerates as unknown (allowing the existing fallback to be used) and suppresses suspicious long audio GAP events before they reach the audio sink.
As a result, both kinds of videos now play correctly.

Comment thread Cargo.toml Outdated
@krakotay
krakotay marked this pull request as draft July 3, 2026 05:51
@krakotay
krakotay marked this pull request as ready for review August 26, 2026 16:42
@krakotay

Copy link
Copy Markdown
Contributor Author

@mmstick due to wash2/iced_video_player#3 merged, the PR is ready for review now

@mmstick
mmstick requested review from a team August 26, 2026 16:55
@leviport leviport self-assigned this Aug 28, 2026

@leviport leviport left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Regression testing passed:

File Operations

  • Selecting a folder with Open media folder opens the directory in the folder pane
  • Selecting media from the folder pane works
  • Open recent media contains a list of recently opened media

Navigation

  • A-B repeat works with video and audio files
  • A-B frame stepping works in video files
  • General media navigation keybinds work and correctly update the timestamp where applicable

@leviport leviport removed their assignment Aug 28, 2026
@krakotay
krakotay requested a review from mmstick August 29, 2026 00:19
@mmstick
mmstick merged commit e040f7f into pop-os:master Aug 29, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants