Repository navigation
fix: release active popup grabs on toplevel destruction. If a window … - #2584
Merged
Merged
Conversation
Drakulix
reviewed
Jul 17, 2026
Drakulix
left a comment
Drakulix
left a comment
Member
There was a problem hiding this comment.
Thanks for tracking this down, couple of remarks:
littlezabi
force-pushed
the
fix/stuck-popup-grabs
branch
3 times, most recently
from
July 17, 2026 20:08
4e6bceb to
8eaf505
Compare
Drakulix
reviewed
Jul 20, 2026
Drakulix
left a comment
Drakulix
left a comment
Member
There was a problem hiding this comment.
Just one little nitpick. Looks good otherwise! Thanks :)
littlezabi
force-pushed
the
fix/stuck-popup-grabs
branch
from
July 20, 2026 16:34
a77b8d4 to
771f6f9
Compare
littlezabi
force-pushed
the
fix/stuck-popup-grabs
branch
from
July 21, 2026 10:51
37ab33f to
91041df
Compare
Drakulix
previously approved these changes
Jul 21, 2026
jklgrasso
previously approved these changes
Jul 21, 2026
Member
|
@littlezabi Can you please run |
If a window with an active popup grab is closed or crashes unexpectedly, the input grab state can get stuck, freezing keyboard and mouse clicks.
This patch iterates over all seats and releases the active seat grab if it is owned by the destroyed window or one of its child popups.
Signed-off-by: littlezabi <zohaibjozvi@gmail.com>
littlezabi
force-pushed
the
fix/stuck-popup-grabs
branch
from
July 21, 2026 14:37
93c88bb to
a7d7bce
Compare
Contributor
Author
|
Drakulix
approved these changes
Jul 21, 2026
jklgrasso
approved these changes
Jul 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Problem
When a client window is destroyed, any active Wayland popup grabs associated with the seat are not automatically cleared. The compositor remains in a grab state, redirecting all keyboard and mouse inputs to a non-existent surface. The user's desktop becomes unresponsive (mouse cursor still moves, but clicks are ignored and keyboard shortcuts stop working).
How to Reproduce
apport-gtkor similar) to spawn a modal popup.I submitted a bug report three weeks ago via the Pop! OS github repository.
check pop-os/pop#4030
Video Demonstration on testing device
41582.1.mp4
System Specifications Summary
Device Model: Lenovo ThinkPad (Modal 20S00043UK)
Processor: Intel(R) Core(TM) i5-10210U
RAM: 16 GB System Memory
GPU: Intel CometLake-U GT2 [UHD Graphics]
Display Interface:
/dev/fb0Storage: 512GB SanDisk SSD
Thank you guys! :) I really like Pop os and appreciate your works