[mayakwd]

Fixes: pop-os/cosmic-epoch#2743

Problem

After the unminimizing animation window receives the wrong size.

Root cause
FloatingLayout::recalculate reconfigures every floating window. When selecting the window geometry, it checks mapped.is_maximized(false), which reflects the committed maximized state. Right after unminimization, the client hasn't acked the maximize yet, so the committed state is still not maximized. As a result, recalculate recomputes the geometry from the old, unmaximized size.

The configure it sends still has the pending-maximized flag set, so the client receives an unmaximized size with the maximized state and renders it small, thinking it's maximized.

Fix
Use the geometry from the pending maximized state (is_maximized(true)) instead of the committed one - intended state, not the client has acked yet.

• I have disclosed use of any AI generated code in my commit messages.
  • If you are using an LLM, and do not fully understand the changes it is making to the code base, do not create a PR.
  • In our experience, AI generated code often results in overly complex code that lacks enough context for a proper fix or feature inclusion. This results in considerably longer code reviews. Due to this, AI authored or partially authored PRs may be closed without comment.
• I understand these changes in full and will be able to respond to review comments.
• My change is accurately described in the commit message.
• My contribution is tested and working as described.
• I have read the Developer Certificate of Origin and certify my contribution under its conditions.

[jacobgkau]

I was able to recreate pop-os/cosmic-epoch#2743 by performing the repro steps on top of another window that's maximized. Confirmed this fixes it. Not seeing any regressions regarding maximized windows keeping their state during other times this recalculate function's used, like when the display scale changes.

[Drakulix]

Thanks!