Skip to content

feat: make tracing-journald dependency optional - #2467

Merged
Drakulix merged 1 commit into
pop-os:masterfrom
lannuttia:feat/make-tracing-journald-optional
Oct 1, 2026
Merged

Drakulix merged 1 commit into
pop-os:masterfrom
lannuttia:feat/make-tracing-journald-optional

Conversation

@lannuttia

@lannuttia lannuttia commented Jun 13, 2026 •

Copy link
Copy Markdown
Contributor
  • I have disclosed use of any AI generated code in my commit messages.
    • If you are using an LLM, and do not fully understand the changes it is making to the code base, do not create a PR.
    • In our experience, AI generated code often results in overly complex code that lacks enough context for a proper fix or feature inclusion. This results in considerably longer code reviews. Due to this, AI authored or partially authored PRs may be closed without comment.
  • I understand these changes in full and will be able to respond to review comments.
  • My change is accurately described in the commit message.
  • My contribution is tested and working as described.
  • I have read the Developer Certificate of Origin and certify my contribution under its conditions.

Make tracing-journald optional behind the systemd feature flag, which is enabled by default. This provides:

  • Smaller binaries for non-systemd systems
  • Removes irrelevant journald error message on non-systemd systems
  • Zero breaking changes (systemd feature enabled by default)

Fixes #2466

@lannuttia
lannuttia marked this pull request as ready for review June 13, 2026 22:03
@lannuttia

Copy link
Copy Markdown
Contributor Author

@mmstick, This should be ready for review.

Drakulix
Drakulix previously approved these changes Jul 13, 2026

@Drakulix Drakulix left a comment •

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just needs a rebase

@Drakulix
Drakulix requested a review from a team July 13, 2026 15:27
@jklgrasso jklgrasso self-assigned this Jul 13, 2026
@jklgrasso

Copy link
Copy Markdown

Looks good. Please resolve the conflict, then I will approve

jklgrasso
jklgrasso previously approved these changes Jul 13, 2026
Drakulix
Drakulix previously approved these changes Oct 1, 2026
@Drakulix

Drakulix commented Oct 1, 2026

Copy link
Copy Markdown
Member

sorry for getting back at this so late. could you rebase?

@lannuttia
lannuttia dismissed stale reviews from Drakulix and jklgrasso via 0647837 October 1, 2026 14:13
@lannuttia
lannuttia force-pushed the feat/make-tracing-journald-optional branch from 3e67be3 to 0647837 Compare October 1, 2026 14:13
@lannuttia

Copy link
Copy Markdown
Contributor Author

@Drakulix, Got it rebased and should be ready to go.

@Drakulix
Drakulix requested a review from a team October 1, 2026 15:14
@Drakulix
Drakulix merged commit 3d55cba into pop-os:master Oct 1, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Make tracing-journald dependency optional

3 participants