Repository navigation
feat: make tracing-journald dependency optional - #2467
Merged
Drakulix merged 1 commit intoOct 1, 2026
Merged
Conversation
lannuttia
marked this pull request as ready for review
June 13, 2026 22:03
Contributor
Author
|
@mmstick, This should be ready for review. |
|
Looks good. Please resolve the conflict, then I will approve |
jklgrasso
previously approved these changes
Jul 13, 2026
Drakulix
previously approved these changes
Oct 1, 2026
Member
|
sorry for getting back at this so late. could you rebase? |
lannuttia
force-pushed
the
feat/make-tracing-journald-optional
branch
from
October 1, 2026 14:13
3e67be3 to
0647837
Compare
Contributor
Author
|
@Drakulix, Got it rebased and should be ready to go. |
Drakulix
approved these changes
Oct 1, 2026
jklgrasso
approved these changes
Oct 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make tracing-journald optional behind the systemd feature flag, which is enabled by default. This provides:
Fixes #2466