Repository navigation
test: move get-property-value.test.js to node test - #580
Merged
Merged
Conversation
Puppo
force-pushed
the
get-property-value-test
branch
from
May 15, 2025 06:27
af693cc to
4c5b4db
Compare
Puppo
marked this pull request as ready for review
May 15, 2025 06:27
mcollina
approved these changes
Jul 29, 2025
mcollina
left a comment
mcollina
left a comment
Member
There was a problem hiding this comment.
LGTM! CI is passing and the test migration to node:test looks good.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR moves
get-property-value.test.jsto node test