Skip to content

objstore: retry on "server sent GOAWAY" http2 error - #60144

Merged
ti-chi-bot[bot] merged 2 commits into
pingcap:masterfrom
joechenrh:retry-error
Mar 18, 2025
Merged

ti-chi-bot[bot] merged 2 commits into
pingcap:masterfrom
joechenrh:retry-error

Conversation

@joechenrh

@joechenrh joechenrh commented Mar 18, 2025 •

Copy link
Copy Markdown
Contributor

What problem does this PR solve?

Issue Number: close #60143

Problem Summary:

What changed and how does it work?

Add "server sent GOAWAY" to retry error list, since gcp support recommends to retry on this error.

And see https://stackoverflow.com/questions/45209168/http2-server-sent-goaway-and-closed-the-connection-laststreamid-1999 for details.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot Bot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/needs-triage-completed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 18, 2025
@tiprow

tiprow Bot commented Mar 18, 2025

Copy link
Copy Markdown

Hi @joechenrh. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@codecov

codecov Bot commented Mar 18, 2025 •

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.8044%. Comparing base (bf21e59) to head (893fad6).
Report is 59 commits behind head on master.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #60144        +/-   ##
================================================
+ Coverage   73.0689%   74.8044%   +1.7355%     
================================================
  Files          1701       1753        +52     
  Lines        469836     489141     +19305     
================================================
+ Hits         343304     365899     +22595     
+ Misses       105363     100559      -4804     
- Partials      21169      22683      +1514     
Flag Coverage Δ
integration 48.8415% <100.0000%> (?)
unit 72.3474% <100.0000%> (+0.0597%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.6910% <ø> (ø)
parser ∅ <ø> (∅)
br 60.4656% <100.0000%> (+13.3836%) ⬆️
🚀 New features to boost your workflow:
  • ❄ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ti-chi-bot ti-chi-bot Bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. and removed do-not-merge/needs-triage-completed labels Mar 18, 2025
@ti-chi-bot

ti-chi-bot Bot commented Mar 18, 2025

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: D3Hunter, lance6716

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot Bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Mar 18, 2025
@ti-chi-bot

ti-chi-bot Bot commented Mar 18, 2025

Copy link
Copy Markdown

[LGTM Timeline notifier]

Timeline:

  • 2025-03-18 07:58:58.874828773 +0000 UTC m=+342432.559064865: ☑️ agreed by lance6716.
  • 2025-03-18 08:23:22.200015065 +0000 UTC m=+343895.884251160: ☑️ agreed by D3Hunter.

@ti-chi-bot
ti-chi-bot Bot merged commit ddfd52a into pingcap:master Mar 18, 2025
zeminzhou pushed a commit to zeminzhou/tidb that referenced this pull request May 6, 2025
@joechenrh
joechenrh deleted the retry-error branch May 27, 2025 10:16
@CbcWestwolf

Copy link
Copy Markdown
Member

/cherrypick release-8.1
/cherrypick release-8.5

ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Jun 23, 2025
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot

Copy link
Copy Markdown
Member

@CbcWestwolf: new pull request created to branch release-8.1: #61937.
But this PR has conflicts, please resolve them!

Details

In response to this:

/cherrypick release-8.1
/cherrypick release-8.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Jun 23, 2025
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot

Copy link
Copy Markdown
Member

@CbcWestwolf: new pull request created to branch release-8.5: #61938.
But this PR has conflicts, please resolve them!

Details

In response to this:

/cherrypick release-8.1
/cherrypick release-8.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

CbcWestwolf pushed a commit to ti-chi-bot/tidb that referenced this pull request Jun 23, 2025
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
CbcWestwolf pushed a commit to ti-chi-bot/tidb that referenced this pull request Jun 23, 2025
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

import task should retry on GCS error server sent GOAWAY

6 participants