Repository navigation
executor: Fix unstable test TestTiKVClientReadTimeout - #57579
ti-chi-bot[bot] merged 2 commits into
Conversation
Signed-off-by: MyonKeminta <MyonKeminta@users.noreply.github.com>
|
Hi @MyonKeminta. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cfzjywxk, hawkingrei, you06 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #57579 +/- ##
================================================
+ Coverage 72.8279% 73.4645% +0.6366%
================================================
Files 1676 1676
Lines 463631 463671 +40
================================================
+ Hits 337653 340634 +2981
+ Misses 105146 102293 -2853
+ Partials 20832 20744 -88
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
|
In response to a cherrypick label: new pull request created to branch |
What problem does this PR solve?
Issue Number: close #57348
Problem Summary:
What changed and how does it work?
After #57050 , the safety check on stale read ts is made strict, making sure that the stale read ts never exceeds that PD has allocated.
However there seems still exists some test code that have some unsafe usage of stale read (such as reading at
now). For these usages, the read ts has chance to exceed PD's max allocated ts, causing the ts validation failed.Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.