Skip to content

executor: Fix unstable test TestTiKVClientReadTimeout - #57579

Merged
ti-chi-bot[bot] merged 2 commits into
pingcap:masterfrom
MyonKeminta:m/fix-test-tikv-client-read-timeout
Nov 21, 2024
Merged

ti-chi-bot[bot] merged 2 commits into
pingcap:masterfrom
MyonKeminta:m/fix-test-tikv-client-read-timeout

Conversation

@MyonKeminta

Copy link
Copy Markdown
Contributor

What problem does this PR solve?

Issue Number: close #57348

Problem Summary:

What changed and how does it work?

After #57050 , the safety check on stale read ts is made strict, making sure that the stale read ts never exceeds that PD has allocated.

However there seems still exists some test code that have some unsafe usage of stale read (such as reading at now). For these usages, the read ts has chance to exceed PD's max allocated ts, causing the ts validation failed.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

Signed-off-by: MyonKeminta <MyonKeminta@users.noreply.github.com>
@ti-chi-bot ti-chi-bot Bot added release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 21, 2024
@tiprow

tiprow Bot commented Nov 21, 2024

Copy link
Copy Markdown

Hi @MyonKeminta. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Signed-off-by: MyonKeminta <MyonKeminta@users.noreply.github.com>
Comment thread pkg/executor/executor_failpoint_test.go Outdated
@ti-chi-bot ti-chi-bot Bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Nov 21, 2024
@ti-chi-bot

ti-chi-bot Bot commented Nov 21, 2024

Copy link
Copy Markdown

[LGTM Timeline notifier]

Timeline:

  • 2024-11-21 07:01:22.787120057 +0000 UTC m=+101470.406774573: ☑️ agreed by you06.
  • 2024-11-21 07:01:33.990616397 +0000 UTC m=+101481.610270913: ☑️ agreed by cfzjywxk.

@ti-chi-bot

ti-chi-bot Bot commented Nov 21, 2024

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cfzjywxk, hawkingrei, you06

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [cfzjywxk,hawkingrei,you06]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov

codecov Bot commented Nov 21, 2024 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 73.4645%. Comparing base (1c059a1) to head (87f59a0).
⚠️ Report is 2190 commits behind head on master.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #57579        +/-   ##
================================================
+ Coverage   72.8279%   73.4645%   +0.6366%     
================================================
  Files          1676       1676                
  Lines        463631     463671        +40     
================================================
+ Hits         337653     340634      +2981     
+ Misses       105146     102293      -2853     
+ Partials      20832      20744        -88     
Flag Coverage Δ
integration 43.6705% <ø> (?)
unit 72.6891% <ø> (+0.0548%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling ∅ <ø> (∅)
parser ∅ <ø> (∅)
br 45.6832% <ø> (-0.0363%) ⬇️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ti-chi-bot
ti-chi-bot Bot merged commit 8d8cfbb into pingcap:master Nov 21, 2024
@you06 you06 added the needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. label Dec 18, 2025
ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Dec 18, 2025
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot

Copy link
Copy Markdown
Member

In response to a cherrypick label: new pull request created to branch release-8.5: #65126.
But this PR has conflicts, please resolve them!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved lgtm needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

flaky test TestTiKVClientReadTimeout

5 participants