Skip to content

BR's "store based backup" version check should be tightened and allow restoring to v8.1.1+ etc. #60990

Closed
#61024
Closed
BR's "store based backup" version check should be tightened and allow restoring to v8.1.1+ etc.#60990
#61024
Labels
affects-8.5This bug affects the 8.5.x(LTS) versions.affects-9.0This bug affects the 9.0.x versions.component/brThis issue is related to BR of TiDB.type/enhancementThe issue or PR belongs to an enhancement.

Description

@kennytm
kennytm
opened on May 7, 2025

Enhancement

tidb/br/pkg/version/version.go

Lines 245 to 252 in 1f32c8e

// 8.2 br(store based backup) does not support tikv <= 8.1
// due to the performance issue https://github.com/tikv/tikv/issues/17168
// TODO: we can remove this check if the performance issue is fixed and cherry-pick
if (BRVersion.Major > 8 || (BRVersion.Major == 8 && BRVersion.Minor >= 2)) &&
(tikvVersion.Major < 8 || (tikvVersion.Major == 8 && tikvVersion.Minor < 2)) {
return errors.Annotatef(berrors.ErrVersionMismatch, "TiKV node %s version %s and BR %s version mismatch, please use the same version of BR",
s.Address, tikvVersion, build.ReleaseVersion)
}

BR starting from v8.2 rejected interacting with TiKV v8.1 or below even with --check-requirements=false because of tikv/tikv#17168. However, the fix has subsequently cherry-picked back to earlier versions:

So, as promised in the TODO, the check should be tightened to check only v6.5.10- / v7.1.5- / v7.5.2- / v8.1.0 or just entirely removed.

Activity

  1. kennytm
    added
    type/enhancementThe issue or PR belongs to an enhancement.
    component/brThis issue is related to BR of TiDB.
    affects-8.5This bug affects the 8.5.x(LTS) versions.
    affects-9.0This bug affects the 9.0.x versions.
    on May 7, 2025
  2. ti-chi-bot
    closed this as completedin #61024on May 10, 2025
  3. ti-chi-bot
    closed this as completedin f3f85fbon May 10, 2025
  4. pull
    added a commit that references this issue on May 10, 2025

    br: remove version checker (pingcap#61024)

    f3f85fb
  5. ti-chi-bot
    added a commit that references this issue on Jun 13, 2025

    br: remove version checker (#61024) (#61549)

    003692e
  6. RidRisR
    added a commit that references this issue on Jun 27, 2025

    br: remove version checker (pingcap#61024) (pingcap#61549)

    e30525e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    affects-8.5This bug affects the 8.5.x(LTS) versions.affects-9.0This bug affects the 9.0.x versions.component/brThis issue is related to BR of TiDB.type/enhancementThe issue or PR belongs to an enhancement.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions