Fix ABBREVIATE strategy to return initials - #62
Merged
jzonthemtn merged 1 commit intoJul 13, 2026
Conversation
Member
|
Thanks @iamvalenciia! |
jzonthemtn
marked this pull request as ready for review
July 13, 2026 16:23
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ABBREVIATEruntime strategy by returning the uppercase initial of each whitespace-separated wordSURNAME,FIRST_NAME, and the PhEye/NER person path, including multi-token and single-token valuesRoot cause
ABBREVIATEwas present in the policy model, butStandardFilterStrategy.GetStandardReplacement(...)had no matching switch arm. Policies could therefore request the strategy, but runtime filters silently fell through to the default redaction behavior.Impact
Values such as
John Smithnow produceJSinstead of a full redaction token. Because the fix is in the shared standard strategy, dictionary name filters and PhEye use the same behavior.Validation
dotnet test tests/Phileas.Tests/Phileas.Tests.csproj --no-restore --verbosity minimalCloses #58