Inconsistent behaviour when stripping bytestrings via CliRunner

[WhyNotHugo]

CliRunner seems to strip bold ansi escape sequences from .output on python2, but they're present on python3.

The doc says color escape codes are removes, but does not mention bold codes. I'm not sure if they're meant to be kept or not, but the behaviour should be consistent across python versions.

[untitaker]

Hmm, this works on both Python versions though:

assert strip_ansi(style('lol', bold=True)) == 'lol'

[untitaker]

The bug seems to be that Click doesn't do any colorcode stripping with echo(b'...') on Python 3.

[untitaker]

Reading through the code, it seems that Click intentionally does not do any code-stripping when the input is bytes.

[WhyNotHugo]

Why does this example use echo() instead of the regular print() function? The answer to this question is that Click attempts to support both Python 2 and Python 3 the same way and to be very robust even when the environment is misconfigured.

source

Looks it's a bug, since the doc states that this sort of discrepancy is exactly what they intend to fix.

[untitaker]

Which is why I'm tagging it as a documentation issue. The code comments describe that particular exception: https://github.com/mitsuhiko/click/blob/master/click/utils.py#L278

[WhyNotHugo]

This isn't the issue in my case anyway. The content I'm printing is unicode on python2 and str on python3.

What you describe may be true, but it's still a separate issue.

[untitaker]

You're right.

[untitaker]

No, actually you're not. This fixes all your tests: https://gist.github.com/untitaker/65042a4c1fd9436ab71d

[WhyNotHugo]

Oh. My check was in the wrong place, I failed to notice that.
Ok, my issue seems to have been a non-issue and bad testing (twice) on my behalf.

I'll leave this open for the documentation fix you mentioned.

[untitaker]

I'm definetly not sure if Click's current behavior is desirable at all though (since it's hard to debug why click didn't rip out escape sequences in this particular case), even though I apprechiate Click's careful approach to encodings.

[mitsuhiko]

Click does not strip colors from bytes, buffer or bytearray on any platform. On Python 2 because we cannot differ str and unicode stripping might happen with quasi bytes there. I do not want to break this behavior because otherwise you cannot echo binary data safely to the terminal.

Why do you need to strip ansi codes on byte data?