Repository navigation
Support inheriting properties in channel programs - #9738
Merged
Merged
Conversation
jasonbking
force-pushed
the
inherit_zcp
branch
from
December 17, 2019 17:23
8e11efb to
439a110
Compare
jasonbking
marked this pull request as ready for review
December 17, 2019 23:37
Codecov Report
@@ Coverage Diff @@
## master #9738 +/- ##
========================================
+ Coverage 79% 80% +<1%
========================================
Files 385 385
Lines 121615 121645 +30
========================================
+ Hits 96636 96868 +232
+ Misses 24979 24777 -202
Continue to review full report at Codecov.
|
behlendorf
reviewed
Dec 18, 2019
behlendorf
reviewed
Jan 13, 2020
behlendorf
approved these changes
Jan 14, 2020
behlendorf
left a comment
behlendorf
left a comment
Contributor
There was a problem hiding this comment.
Looks good, and works as intended for me. If you can rebase this on master, which will resolve the make lint warnings, and resolve the minor man page edits this should be good to go.
This adds support in channel programs to inherit properties analogous to `zfs inherit` by adding `zfs.sync.inherit` and `zfs.check.inherit` functions to the ZFS LUA API. Signed-off-by: Jason King <jason.king@joyent.com>
jasonbking
force-pushed
the
inherit_zcp
branch
from
January 15, 2020 19:34
778f0d0 to
76465fd
Compare
behlendorf
added
Status: Accepted
Contributor
|
I'd like to get this merged by next Wednesday, please post any comments you may have by then. |
Member
|
@jasonbking Sorry I didn't have time to look at this before it was integrated. The code looks good to me. Thanks for extending zfs channel programs! |
jsai20
pushed a commit
to jsai20/zfs
that referenced
this pull request
Mar 30, 2021
This adds support in channel programs to inherit properties analogous to `zfs inherit` by adding `zfs.sync.inherit` and `zfs.check.inherit` functions to the ZFS LUA API. Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Signed-off-by: Jason King <jason.king@joyent.com> Closes openzfs#9738
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add
zfs.sync.inheritandzfs.check.inheritfunctions for ZFS channel programs that functions like thezfs inheritcommand.Motivation and Context
Joyent has been using this as component of our key management system we've been developing for Triton (as described in the OpenZFS summit presentation). The feature itself seems generally useful in more contexts that it makes sense to contribute it to the broader community.
Description
Functions where added to implement the
zfs.sync.inheritandzfs.check.inheritLUA functions, following the form of the existing channel program functions. The check function performs the same checks on the property that thezfs inheritcommand performs. We did not however implement support forzfs inherit -S, as it wasn't necessary for our uses, though nothing in the implementation should prohibit adding the functionality in the future if desired.How Has This Been Tested?
This has been running on a SmartOS branch for some time (we want to get wider review before integrating it into the master branch of any repo) using the added functionality. In addition, the added zfs test case runs successfully.
Types of changes
Checklist:
Signed-off-by.