Repository navigation
Add 'zfs umount -u' for encrypted datasets - #8952
Merged
Merged
Conversation
Contributor
|
If I understood that correctly (haven't tried it, just looked at the code): if it's an encryption root, and it has unmounted it, but cannot unload the key, it will then remount it and fail the operation? Shouldn't the option be documented in a man page? |
behlendorf
approved these changes
Jun 26, 2019
behlendorf
left a comment
behlendorf
left a comment
Contributor
There was a problem hiding this comment.
After adding the -u option to the man page as @kithrup mentioned, this looks good to me.
This patch adds the ability for the user to unload keys for datasets as they are being unmounted. This is analagous to 'zfs mount -l'. Fixes: openzfs#8917 Signed-off-by: Tom Caputi <tcaputi@datto.com>
Codecov Report
@@ Coverage Diff @@
## master #8952 +/- ##
==========================================
+ Coverage 78.54% 78.68% +0.14%
==========================================
Files 388 382 -6
Lines 119950 117786 -2164
==========================================
- Hits 94213 92679 -1534
+ Misses 25737 25107 -630
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch adds the ability for the user to unload keys for
datasets as they are being unmounted. This is analagous to
'zfs mount -l'.
Signed-off-by: Tom Caputi tcaputi@datto.com
Types of changes
Checklist:
Signed-off-by.