Repository navigation
Review HloInstruction::CreateFromProto and double-check that we haven't missed anything #565
Description
Recently, I came across HloInstruction::CreateFromProto, and I think that it provides a very nice summary of which HLO opcodes support which metadata.
In HloInstructionProto, all kinds of metadata are packed into the same proto message, and the Operation Semantics page is not 100% up to date, so it was nice to discover an authoritative resource on the matter.
We should review this method and double-check if we missed anythin when speccing StableHLO.
Activity
[-]Review HloInstruction::CreateFromProto and double-check if we missed anything[/-][+]Review HloInstruction::CreateFromProto and double-check that we haven't missed anything[/+]burmako commentedon Nov 24, 2022
For example, here's one thing that we missed: kParameter::parameter_replicated_at_leaf_buffers.
burmako commentedon Nov 25, 2022
I've reviewed all the ops that we have already specced and found only a few gaps mentioned above in the GitHub UI in referenced tickets. None of these gaps look significant, which is great - this means that speccing is going very well.
The rest of the ops will be reviewed as we go according to the checklist, which is proposed to be expanded with this procedure in #625.
Expand the checklist to include HloInstruction::CreateFromProto (#625)