Always parse non-project resources - #1168
Merged
Merged
Conversation
The CLI used to depend on the maven plugin and needed resource parsing to be optional. That is no longer the case, so drop the parseAdditionalResources flag and always parse non-project resources.
mergify Bot
added a commit
to robfrank/linklift
that referenced
this pull request
Jul 17, 2026
âĶ 6.42.0 to 6.44.0 [skip ci] Bumps [org.openrewrite.maven:rewrite-maven-plugin](https://github.com/openrewrite/rewrite-maven-plugin) from 6.42.0 to 6.44.0. Release notes *Sourced from [org.openrewrite.maven:rewrite-maven-plugin's releases](https://github.com/openrewrite/rewrite-maven-plugin/releases).* > 6.44.0 > ------ > > What's Changed > -------------- > > * Suppress CVE-2026-53914 and jackson-databind false positives by [`@âtimtebeek`](https://github.com/timtebeek) in [openrewrite/rewrite-maven-plugin#1172](https://redirect.github.com/openrewrite/rewrite-maven-plugin/pull/1172) > * Update jackson-bom.version to 2.21.5 by [`@âtimtebeek`](https://github.com/timtebeek) in [openrewrite/rewrite-maven-plugin#1173](https://redirect.github.com/openrewrite/rewrite-maven-plugin/pull/1173) > * chore(ci): bump org.junit:junit-bom from 6.1.1 to 6.1.2 by [`@âdependabot`](https://github.com/dependabot)[bot] in [openrewrite/rewrite-maven-plugin#1175](https://redirect.github.com/openrewrite/rewrite-maven-plugin/pull/1175) > > **Full Changelog**: <openrewrite/rewrite-maven-plugin@v6.43.0...v6.44.0> > > 6.43.0 > ------ > > What's Changed > -------------- > > * Always parse non-project resources by [`@âtimtebeek`](https://github.com/timtebeek) in [openrewrite/rewrite-maven-plugin#1168](https://redirect.github.com/openrewrite/rewrite-maven-plugin/pull/1168) > * chore(ci): bump com.fasterxml.jackson:jackson-bom from 2.21.3 to 2.21.4 by [`@âdependabot`](https://github.com/dependabot)[bot] in [openrewrite/rewrite-maven-plugin#1159](https://redirect.github.com/openrewrite/rewrite-maven-plugin/pull/1159) > * Tolerate Develocity remote build cache warnings in BasicIT by [`@âtimtebeek`](https://github.com/timtebeek) in [openrewrite/rewrite-maven-plugin#1171](https://redirect.github.com/openrewrite/rewrite-maven-plugin/pull/1171) > * chore(ci): bump org.junit:junit-bom from 6.1.0 to 6.1.1 by [`@âdependabot`](https://github.com/dependabot)[bot] in [openrewrite/rewrite-maven-plugin#1170](https://redirect.github.com/openrewrite/rewrite-maven-plugin/pull/1170) > > **Full Changelog**: <openrewrite/rewrite-maven-plugin@v6.42.0...v6.43.0> Commits * [`4057afc`](openrewrite/rewrite-maven-plugin@4057afc) [maven-release-plugin] prepare release v6.44.0 * [`4863ff6`](openrewrite/rewrite-maven-plugin@4863ff6) Bump rewrite.version property * [`c397755`](openrewrite/rewrite-maven-plugin@c397755) chore(ci): bump org.junit:junit-bom from 6.1.1 to 6.1.2 ([#1175](https://redirect.github.com/openrewrite/rewrite-maven-plugin/issues/1175)) * [`b16d163`](openrewrite/rewrite-maven-plugin@b16d163) Update jackson-bom.version to 2.21.5 ([#1173](https://redirect.github.com/openrewrite/rewrite-maven-plugin/issues/1173)) * [`67a0031`](openrewrite/rewrite-maven-plugin@67a0031) Suppress CVE-2026-53914 and jackson-databind false positives ([#1172](https://redirect.github.com/openrewrite/rewrite-maven-plugin/issues/1172)) * [`c3bdcc5`](openrewrite/rewrite-maven-plugin@c3bdcc5) Bump rewrite.version property * [`3cd0cce`](openrewrite/rewrite-maven-plugin@3cd0cce) Remove configuration to fail on CVSS >= 9.0 * [`06e64cb`](openrewrite/rewrite-maven-plugin@06e64cb) Bump rewrite.version property * [`1877e3c`](openrewrite/rewrite-maven-plugin@1877e3c) [maven-release-plugin] prepare for next development iteration * [`269bf8c`](openrewrite/rewrite-maven-plugin@269bf8c) [maven-release-plugin] prepare release v6.43.0 * Additional commits viewable in [compare view](openrewrite/rewrite-maven-plugin@v6.42.0...v6.44.0) [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot show ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Earlier the CLI depended on the maven plugin and required non-project resource parsing to be optional, which is why
MavenMojoProjectParsercarried aparseAdditionalResourcesflag. That accommodation is no longer necessary, so this removes the flag (the field, constructor parameter, and early-return guard) and always parses non-project resources. The maven plugin already passedtrue, so behavior is unchanged.