Repository navigation
Add next link requirement - #166
Merged
Merged
Conversation
Addresses part of #165, by adding an explicit requirement to the README that paginated payloads should include a `next` key at a minimum.
thekaveman
previously approved these changes
Nov 7, 2018
thekaveman
left a comment
thekaveman
left a comment
Collaborator
There was a problem hiding this comment.
LGTM. There is an extra space that snuck in on the end of line 42, but no biggie.
Following discussion #165, suggestion adds a explicit requirement for the last page of any paginated payload to return a value of `null` for the `next` key.
hunterowens
approved these changes
Nov 8, 2018
hunterowens
added a commit
that referenced
this pull request
Dec 4, 2018
* 0.2.1: (61 commits) updating release notes for 0.2.x fix for required properties in generated schema add WIND as a dockless mobility provider (#185) add Spin as a dockless mobility provider (#184) Reverts PR #146, moving Timestamp change into future release (#180) wheels (#177) adding info about mailing list. (#175) Adding Release guidelines (#147) Update providers.csv (#174) Add `next` link requirement (#166) Add OAauth client_credentials auth guidelines section update JUMP provider URL (#164) allowing null for links.next (#162) Agency vs Provider Clarification. [#148] (#150) Add LADOT Guidelines for the Handling of MSP Data (#154) allowing for null links properties Suggestion: Add Clarification to Propulsion Types fix versions remove oneOf when required is being added regenerate the schemas ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses part of #165, by adding an explicit requirement to the README that paginated payloads should include a
nextkey at a minimum.