Skip to content

Clarification needed on possible values of rule_units #704

Closed

Description

@janedotx

Is your feature request related to a problem? Please describe.

In the policy README, rule_units is amount for a rate rule type, but it could be a unit of time instead if the rate rule has a recurrence of each_time_unit or per_complete_time_unit.

Describe the solution you'd like

Get rid of amount as a valid value for rule_units. There doesn't seem to be much point in having rule_units have a value of amount just for rate rules that recur only once.

Is this a breaking change

I don't think this is breaking. If you write a recurring rate rule, you already have to set rule_units to some sort of time unit to have the rule make sense in the first place.

  • No, not breaking

Impacted Spec

For which spec is this feature being requested?

  • policy

Describe alternatives you've considered

We could leave it as is, but it seems very confusing to me.

Additional context

Add any other context or screenshots about the feature request here.

Activity

  1. added this to the 2.0.0 milestone on Oct 27, 2021
  2. schnuerle commented on Dec 19, 2022

    @schnuerle
    Member

    This may be addressed as part of the Policy re-work lead by @S-eb and @jean-populus.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    PolicySpecific to the Policy API

    Type

    No type

    Projects

    No projects

      Milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions