Skip to content

OpenAPI Support - #100

Merged
schnuerle merged 15 commits into
devfrom
feature-openapi
Dec 12, 2023
Merged

schnuerle merged 15 commits into
devfrom
feature-openapi

Conversation

@schnuerle

Copy link
Copy Markdown
Member

Explain pull request

Adding context and files to define CDS using OpenAPI.

Is this a breaking change

  • No, not breaking

Impacted Spec

Which API(s) will this pull request impact?

  • Curbs
  • Events
  • Metrics

Additional context

This is useful in validating and viewing CDS data feeds. See issue #87 for more details.

@schnuerle
schnuerle requested a review from a team as a code owner July 8, 2022 15:37
@CLAassistant

CLAassistant commented Jul 8, 2022 •

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@schnuerle schnuerle added Curbs API schema Implications for the OpenAPI Schema labels Jul 8, 2022
@schnuerle schnuerle linked an issue Jul 8, 2022 that may be closed by this pull request
@schnuerle schnuerle mentioned this pull request Jul 8, 2022
@schnuerle
schnuerle marked this pull request as draft July 8, 2022 15:41
@schnuerle

Copy link
Copy Markdown
Member Author

Comment thread curbs/curbs.yaml Outdated
@schnuerle

Copy link
Copy Markdown
Member Author

I do get these errors when in Stoplight. Do you see that too?

762 - schema is invalid: data/properties/length/exclusiveMinimum must be number
762 - exclusiveMinimum value must be ["number"]
830 - "0" property type must be number
909 - "0" property type must be number
1135 - "user_classes" property type must be string

@BigIdeas

BigIdeas commented Jul 8, 2022

Copy link
Copy Markdown
Contributor

I do get these errors when in Stoplight. Do you see that too?

No, that's really strange, I wasn't seeing any errors in Stoplight but those were all real problems. I just pushed an update that should fix them.

@schnuerle

Copy link
Copy Markdown
Member Author

This PR is going to get reworked to point to definitions in an external repo.

https://github.com/openmobilityfoundation/cds-openapi/tree/v1.0.0-dev

@schnuerle schnuerle added this to the 1.0.1 milestone Jun 7, 2023
@schnuerle
schnuerle marked this pull request as ready for review November 20, 2023 15:58
@schnuerle
schnuerle merged commit a1b7945 into dev Dec 12, 2023
@schnuerle

Copy link
Copy Markdown
Member Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Curbs API schema Implications for the OpenAPI Schema

Projects

None yet

Development

Successfully merging this pull request may close these issues.

OpenAPI Definition

3 participants