Skip to content

fix: keep notifications and show an error when marking all as read fails - #3886

Merged
AlexAndBear merged 1 commit into
mainfrom
fix/notifications-markall-error
Oct 19, 2026
Merged

AlexAndBear merged 1 commit into
mainfrom
fix/notifications-markall-error

Conversation

@AlexAndBear

@AlexAndBear AlexAndBear commented Oct 18, 2026 •

Copy link
Copy Markdown
Member

Description

The notifications are now only removed after a successful delete; a failed request shows an error instead of silently emptying the list.

Related Issue

How Has This Been Tested?

  • test environment: unit tests (Vitest), browser tests (Playwright) against a local OpenCloud
  • test case 1: unit: a failed delete keeps the notifications and shows an error
  • test case 2: browser: failed request (500 and network error) keeps list and badge and shows the error; success empties the list; new notifications still arrive

Types of changes

  • Bugfix
  • Enhancement (a change that doesn't break existing code or deployments)
  • Breaking change (a modification that affects current functionality)
  • Technical debt (addressing code that needs refactoring or improvements)
  • Tests (adding or improving tests)
  • Documentation (updates or additions to documentation)
  • Maintenance (like dependency updates or tooling adjustments)

@AlexAndBear
AlexAndBear merged commit 6cd64be into main Oct 19, 2026
28 checks passed
@AlexAndBear
AlexAndBear deleted the fix/notifications-markall-error branch October 19, 2026 08:55
@openclouders openclouders mentioned this pull request Oct 19, 2026
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

A failed "Mark all as read" silently empties the notification list

2 participants