Repository navigation
fix: copy link without ClipboardItem and keep the clipboard when there is no single link - #3871
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
typeof ClipboardItem && navigator.clipboard.writewas always true on its first part and threw wherenavigator.clipboardis missing (insecure context). It now checkstypeof ClipboardItem !== 'undefined' && navigator.clipboard?.write, so browsers withoutClipboardItemuse the fallback and the link is still created without clipboard access.useClipboard({ legacy: true })lets the fallback copy throughexecCommandwhen the Clipboard API is missing, like the other copy buttons do. The secure-context path is unchanged.Related Issue
How Has This Been Tested?
Types of changes