Skip to content

fix: let space toggle a focused checkbox in lists - #3752

Merged
AlexAndBear merged 3 commits into
mainfrom
fix/admin-space-key-checkbox
Oct 16, 2026
Merged

AlexAndBear merged 3 commits into
mainfrom
fix/admin-space-key-checkbox

Conversation

@AlexAndBear

Copy link
Copy Markdown
Member

Description

  • Admin settings lists and files table: pressing Space on a focused row checkbox toggles that row instead of the last selected one, in admin Groups, Users and Spaces and in the files table, tiles view and Shared with me.
  • Unchanged: Space with the focus elsewhere still toggles the last selected row and doesn't scroll the page.

Related Issue

How Has This Been Tested?

  • test environment: unit tests (Vitest), browser tests (Playwright) against a local OpenCloud
  • test case 1: Space on a focused checkbox leaves the toggle to the checkbox, Space elsewhere toggles the last selected row and prevents the default
  • test case 2: browser: select row 1, tab to row 3's checkbox, Space selects row 3, again deselects it, in all six lists; arrow keys, Shift+Arrow and typing spaces in inputs unchanged

Types of changes

  • Bugfix
  • Enhancement (a change that doesn't break existing code or deployments)
  • Breaking change (a modification that affects current functionality)
  • Technical debt (addressing code that needs refactoring or improvements)
  • Tests (adding or improving tests)
  • Documentation (updates or additions to documentation)
  • Maintenance (like dependency updates or tooling adjustments)

@AlexAndBear
AlexAndBear merged commit fb5c58f into main Oct 16, 2026
28 checks passed
@AlexAndBear
AlexAndBear deleted the fix/admin-space-key-checkbox branch October 16, 2026 13:20
@openclouders openclouders mentioned this pull request Oct 16, 2026
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Space on a focused row checkbox toggles the last selected row instead (admin lists and files table)

2 participants